emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rainer M Krug <Rainer@krugs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ox-latex.el: add out-of-the-box fontification for makefile source block
Date: Wed, 16 Jul 2014 14:56:55 +0200	[thread overview]
Message-ID: <87mwc9jwbs.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m2ha2rasn3.fsf@krugs.de> (Rainer M. Krug's message of "Wed, 09 Jul 2014 09:38:40 +0200")

Hello,

Rainer M Krug <Rainer@krugs.de> writes:

> THis patch adds out-of-the-box fontification of makefile source code
> blocks when using the package listings. As the makefile code blocks are
> named =makefile= and the name of the language definition in the package
> =listings= is m=make= the value (makefile "make") is added to the
> variable org-latex-listings-langs.

Thank you for the patch. Since you modify the default value of
a defcustom, could you also add :version and :package-version keywords
to the variable? See `org-latex-known-warnings' for an example.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2014-07-16 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09  7:38 [PATCH] ox-latex.el: add out-of-the-box fontification for makefile source block Rainer M Krug
2014-07-16 12:56 ` Nicolas Goaziou [this message]
2014-07-22  9:44   ` Rainer M Krug
2014-07-27 14:21     ` Bastien
2014-08-14 10:52       ` Rainer M Krug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwc9jwbs.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=Rainer@krugs.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).