From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rasmus <rasmus@gmx.us>
Cc: emacs-orgmode@gnu.org
Subject: Re: [bug?, org-element] latex-environment delimiters must be at BOL
Date: Sun, 20 Jul 2014 19:49:28 +0200 [thread overview]
Message-ID: <87mwc3gbtj.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vbqu1xb6.fsf@gmx.us> (rasmus@gmx.us's message of "Fri, 18 Jul 2014 17:49:49 +0200")
Hello,
Rasmus <rasmus@gmx.us> writes:
> I changed a couple of things,
A couple of things? AFAIU, it only requires to change the regexp in
`org-element-latex-environment-parser', doesn't it?
[...]
> 2. Load my modified org-element.el file and rerun tests.
> The only new fail is this one, that is to be expected to fail.
>
> (should-not
> (eq 'latex-environment
> (org-test-with-temp-text "\\begin{env}{arg} something\nvalue\n\\end{env}"
> (org-element-type (org-element-at-point)))))
OK.
> Hence, my question is: Can I now assume that my modification are now
> somewhat safe wrt. the current Org syntax?
You should also add tests specifics to the new behaviour.
> I have a case that I worry a bit about, namely broken LaTeX code with
> mismatching no. of begin/end tags:
>
> Consider:
>
> #+begin_src org
> \begin{equation} x^2_3
> \begin{equation} x^2_3 \end{equation}
> #+end_src
>
> With my patch, this will produce (*):
>
> #+begin_src latex
> \begin{equation} x^2_3
> \begin{equation} x^2_3 \end{equation}
> #+end_src latex
This looks "correct". It is a valid latex-environment element even
though it is not valid LaTeX syntax.
> I will write some tests and review the two documents you mention and
> submit a patch ASAP.
OK. Thank you for that.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2014-07-20 17:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 11:54 [bug?, org-element] latex-environment delimiters must be at BOL Rasmus
2014-07-16 13:04 ` Nicolas Goaziou
2014-07-18 15:49 ` Rasmus
2014-07-20 17:49 ` Nicolas Goaziou [this message]
2014-07-21 9:29 ` Rasmus
2014-07-22 7:54 ` Nicolas Goaziou
2014-07-22 9:08 ` Rasmus
2014-07-22 10:03 ` Nicolas Goaziou
2014-07-22 13:28 ` Rasmus
2014-07-23 8:29 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwc3gbtj.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).