From: Bastien <bzg@gnu.org>
To: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]
Date: Mon, 28 Jul 2014 16:18:10 +0200 [thread overview]
Message-ID: <87mwbtxuob.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87r41a6dfw.fsf@geodiff-mac3.ulb.ac.be> (Nicolas Richard's message of "Thu, 24 Jul 2014 16:25:55 +0200")
Hi Nicolas,
Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:
> But now that I think about it, org mode simply should avoid narrow-map
> completely : users (me included) won't randomly try to run
> org-narrow-to-subtree outside of org buffers (and those who do deserve a
> bad error message) but they might want to give "C-x n s" a try if it is
> available.
>
> While writing a patch for changing that, I see that the code is:
> (if (boundp 'narrow-map)
> (org-defkey narrow-map "s" 'org-narrow-to-subtree)
> (org-defkey org-mode-map "\C-xns" 'org-narrow-to-subtree))
> (if (boundp 'narrow-map)
> (org-defkey narrow-map "b" 'org-narrow-to-block)
> (org-defkey org-mode-map "\C-xnb" 'org-narrow-to-block))
> (if (boundp 'narrow-map)
> (org-defkey narrow-map "e" 'org-narrow-to-element)
> (org-defkey org-mode-map "\C-xne" 'org-narrow-to-element))
>
> IOW, org.el purposely binds in narrow-map ! So now I don't get it :
> either it's in narrow-map and should be usable widely, or it's in
> org-mode-map only for org-mode files.
I think it's fine to bind `org-narrow-to-subtree' in narrow-map.
It's basically to enjoy the `C-x n prefix', which is natural here.
I applied your patch, but a good continuation would be to have
C-h n s bound to `outline-narrow-to-subtree' in outline-mode and
to `org-narrow-to-subtree' in org-mode, instead of just relying
on one single function.
This requires simplifying `org-narrow-to-subtree' and creating
`outline-narrow-to-subtree' in emacs.
What do you think?
--
Bastien
next prev parent reply other threads:[~2014-07-28 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 17:48 Bug: [PATCH] Make org-narrow-to-subtree usable out of Org mode [8.2.7b (release_8.2.7b-6-g07d470 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] Nicolas Richard
2014-07-24 7:48 ` Nicolas Goaziou
2014-07-24 13:28 ` Nicolas Richard
2014-07-24 14:02 ` Nicolas Goaziou
2014-07-24 14:25 ` Nicolas Richard
2014-07-24 15:00 ` Thorsten Jolitz
2014-07-25 9:13 ` Nicolas Goaziou
2014-07-28 14:18 ` Bastien [this message]
2014-07-30 14:51 ` Nicolas Richard
2014-07-30 15:20 ` Thorsten Jolitz
2014-07-30 15:37 ` Nicolas Richard
2014-07-30 16:30 ` Thorsten Jolitz
2014-07-31 8:00 ` Nicolas Richard
2014-07-28 14:15 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwbtxuob.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).