emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Saulius Menkevičius" <saulius.menkevicius@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/ob-sql.el: add support for :dbport parameter
Date: Tue, 07 Apr 2015 22:27:33 +0200	[thread overview]
Message-ID: <87mw2jptu2.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m26197q1ri.fsf@mbp.Dlink> ("Saulius \=\?utf-8\?Q\?Menkevi\=C4\=8Di\?\= \=\?utf-8\?Q\?us\=22's\?\= message of "Tue, 07 Apr 2015 20:36:17 +0300")

Saulius Menkevičius <saulius.menkevicius@gmail.com> writes:

> Apparently it is not a string. I don't know the internal machinery for
> #+header parameters in org-mode/babel, but apparently number-to-string
> is required, otherwise I get the "progn: Wrong type argument: sequencep,
> 33060" error. Where 33060 is my port number from the :dbport param.

OK. I slightly changed this line.

>> Nitpick: `assoc' -> `assq'
> Ok. I did not know much of elisp to decide on which one to. This was
> copy-paste code from previous line, sorry.

The previous lines should use `assq', but that's not very important.

> Updated patch is attached to this mail.

Applied. Thank you.


      reply	other threads:[~2015-04-07 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 20:34 [PATCH] lisp/ob-sql.el: add support for :dbport parameter Saulius Menkevičius
2015-04-07  4:49 ` Xavier Maillard
2015-04-07 17:12   ` Saulius Menkevičius
2015-04-07  6:17 ` Nicolas Goaziou
2015-04-07 17:36   ` Saulius Menkevičius
2015-04-07 20:27     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mw2jptu2.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=saulius.menkevicius@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).