From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org-clone-subtree-with-time-shift: Accept 0 clones Date: Mon, 22 Jun 2015 10:12:59 +0200 Message-ID: <87mvzstb3o.fsf@nicolasgoaziou.fr> References: <87h9q08pqi.fsf@kmlap.domain.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6wpM-0000Hb-Or for emacs-orgmode@gnu.org; Mon, 22 Jun 2015 04:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z6wpK-0001Bv-T1 for emacs-orgmode@gnu.org; Mon, 22 Jun 2015 04:11:36 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:46143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z6wpK-0001Bi-Ml for emacs-orgmode@gnu.org; Mon, 22 Jun 2015 04:11:34 -0400 In-Reply-To: <87h9q08pqi.fsf@kmlap.domain.org> (Kyle Meyer's message of "Sun, 21 Jun 2015 22:02:29 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kyle Meyer Cc: Org-mode Hello, Kyle Meyer writes: > From 37a917e4f7e4d2c05355735ab08f1f555b9dc942 Mon Sep 17 00:00:00 2001 > From: Kyle Meyer > Date: Sun, 21 Jun 2015 21:46:54 -0400 > Subject: [PATCH] org-clone-subtree-with-time-shift: Accept 0 clones Thank you for the patch. > - (if (not (and (integerp n) (> n 0))) > + (if (not (and (integerp n) (>= n 0))) > (user-error "Invalid number of replications %s" n)) Nitpick: (unless (wholenump n) (user-error ...)) Otherwise, looks good. Regards, -- Nicolas Goaziou