From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode Date: Fri, 14 Aug 2015 17:53:32 +0200 Message-ID: <87mvxteuir.fsf@nicolasgoaziou.fr> References: <87fv3q2lxs.fsf@gmx.us> <878u9ic8sv.fsf@nicolasgoaziou.fr> <87zj1y0zst.fsf@gmx.us> <874mk6c7sz.fsf@nicolasgoaziou.fr> <87pp2u0x60.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQHHW-0003hE-8g for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 11:52:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQHGt-0003KU-Te for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 11:51:56 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:40182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQHGt-0003K3-N2 for emacs-orgmode@gnu.org; Fri, 14 Aug 2015 11:51:55 -0400 In-Reply-To: <87pp2u0x60.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 11 Aug 2015 15:31:03 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > Great. The bad commit seems to be: > > commit 898cfbcac0560d1d742d939a62c5a8253fe9b66f > Author: Nicolas Goaziou > Date: Mon Aug 10 13:34:07 2015 +0200 > > Implement faster `show-children' function > > * lisp/org.el (org-show-children): New function. > (org-cycle-internal-local): > (org-set-visibility-according-to-property): > (org-content): > (org-move-subtree-down): > (orgstruct-setup): > (org-show-set-visibility): > * contrib/lisp/org-toc.el (org-toc-cycle-subtree): > (org-toc-restore-config): > * lisp/org-agenda.el (org-agenda-show-1): > * lisp/org-feed.el (org-feed-update): Use new function. > > * etc/ORG-NEWS: Document new function. > > Suggested-by: Samuel Wales > > > I guess I will have to dissect it more to figure out what broke. `org-cycle-internal-local' calls `org-show-children', which is the Org specific implementation of `show-children'. I don't think orgstruct details should leak into `org-show-children', so I suggest to plug orgstruct stuff, i.e., make sure `show-children' is called instead of `org-show-children', elsewhere. One possibility is to use a hook in `org-cycle', not sure which one though. `orgstruct-mode' could also assume its kludge status and use something like `add-function'. WDYT? Regards,