emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: org-collector evaluates headlines starting with hyperlink as lisp code
@ 2018-04-23 17:54 Martin Kampas
  2018-04-26 23:34 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Kampas @ 2018-04-23 17:54 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

With headlines like

* [[http://example.com]] Example

org-collector writes just "http://example.com" in the table, omitting the rest of the headline.

Patch below.

BR,
Martin

From 1228efc453d38bc090511f21fafa750e416e8b7a Mon Sep 17 00:00:00 2001
From: Martin Kampas <martin.kampas@ubedi.net>
Date: Mon, 23 Apr 2018 19:27:18 +0200
Subject: [PATCH] org-collector.el: Inhibit lisp evaluation of headlines

* contrib/lisp/org-collector.el (org-propview-collect): Inhibit lisp
  evaluation of headlines

This fixes org-collector usage for items starting with a hyperlink,
which would be incorrectly treated as lisp code.
---
 contrib/lisp/org-collector.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/contrib/lisp/org-collector.el b/contrib/lisp/org-collector.el
index 1d2351923..833ecbf51 100644
--- a/contrib/lisp/org-collector.el
+++ b/contrib/lisp/org-collector.el
@@ -186,7 +186,8 @@ variables and values specified in props"
 	 (header-props
 	  (mapcar (lambda (props)
 		    (mapcar (lambda (pair)
-			      (cons (car pair) (org-babel-read (cdr pair))))
+			      (let ((inhibit-lisp-eval (string= (car pair) "ITEM")))
+				(cons (car pair) (org-babel-read (cdr pair) inhibit-lisp-eval))))
 			    props))
 		  header-props))
 	 ;; collect all property names
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Bug: org-collector evaluates headlines starting with hyperlink as lisp code
  2018-04-23 17:54 Bug: org-collector evaluates headlines starting with hyperlink as lisp code Martin Kampas
@ 2018-04-26 23:34 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2018-04-26 23:34 UTC (permalink / raw)
  To: Martin Kampas; +Cc: emacs-orgmode

Hi Martin,

Martin Kampas <martin.kampas@ubedi.net> writes:

> With headlines like
>
> * [[http://example.com]] Example
>
> org-collector writes just "http://example.com" in the table, omitting the rest of the headline.
>
> Patch below.

Applied in maint, thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-26 23:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 17:54 Bug: org-collector evaluates headlines starting with hyperlink as lisp code Martin Kampas
2018-04-26 23:34 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).