emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Thomas Plass <thunk2@arcor.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p
Date: Mon, 18 Mar 2019 22:43:13 +0100	[thread overview]
Message-ID: <87mulrsvta.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <23692.5492.62319.323977@AGAME7.local> (Thomas Plass's message of "Fri, 15 Mar 2019 22:13:24 +0100")

Hello,

thunk2@arcor.de (Thomas Plass) writes:

> it's counter-intuitive that 'org-at-date-range-p doesn't work like
> 'org-at-timestamp-p when point is on the leading bracket of a range.
> Witness (^ = point)
>
> <2019-12-30 Mo 12:00>
> ^ (org-at-timestamp-p)                            => t
>
> <2019-12-30 Mo 12:00>--<2019-12-31 Di 09:00>
> ^ (org-at-timestamp-p)                            => t
>  ^ (org-at-date-range-p)                          => t
> ^ (org-at-date-range-p)                           => nil
>
> Is the attached patch OK?

Thank you.

I think the incompatibility is deeper than that. IMO,
`org-at-date-range-p' should obey to the same arguments as
`org-at-timestamp-p'. IOW, a rewrite is in order.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-03-18 21:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 21:13 [PATCH] make 'org-at-date-range-p work like org-at-timestamp-p Thomas Plass
2019-03-18 21:43 ` Nicolas Goaziou [this message]
2019-03-19 19:46   ` Thomas Plass
2019-03-19 19:49   ` Thomas Plass
2019-03-19 20:28     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mulrsvta.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=thunk2@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).