From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SEuhAn+Tw14fdgAA0tVLHw (envelope-from ) for ; Tue, 19 May 2020 08:06:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WCPwOX6Tw15BJQAAbx9fmQ (envelope-from ) for ; Tue, 19 May 2020 08:06:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F81F940712 for ; Tue, 19 May 2020 08:06:22 +0000 (UTC) Received: from localhost ([::1]:55922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaxGV-0001Dh-NS for larch@yhetil.org; Tue, 19 May 2020 04:06:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaxFD-00016i-4N for emacs-orgmode@gnu.org; Tue, 19 May 2020 04:04:59 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38947) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaxFB-0002Q2-G3 for emacs-orgmode@gnu.org; Tue, 19 May 2020 04:04:58 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 99382C0018; Tue, 19 May 2020 08:04:52 +0000 (UTC) From: Nicolas Goaziou To: Kyle Meyer Subject: Re: `#+author:' stopped setting the author to empty string References: <87v9ksstwc.fsf@kyleam.com> Mail-Followup-To: Kyle Meyer , Kaushal Modi , emacs-org list Date: Tue, 19 May 2020 10:04:51 +0200 In-Reply-To: <87v9ksstwc.fsf@kyleam.com> (Kyle Meyer's message of "Mon, 18 May 2020 23:30:43 +0000") Message-ID: <87mu64jqos.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.198; envelope-from=mail@nicolasgoaziou.fr; helo=relay6-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/19 03:47:24 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-org list , Kaushal Modi Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: XJXGwQZeQLrh Hello, Kyle Meyer writes: > It bisects to b4e91b7e9 (New function: org-collect-keywords, > 2020-04-26). I haven't done much digging, but I was able to restore the > behavior with the change below, which may be a bad idea for other > reasons. > > diff --git a/lisp/org.el b/lisp/org.el > index 0e1e05239..a8db4c2bf 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -4501,7 +4501,6 @@ (defun org--collect-keywords-1 (keywords uniques files alist) > (push (cons key value) alist) > (setq keywords (remove key keywords)) > (setq regexp (org-make-options-regexp keywords))) > - ((not (org-string-nw-p value)) nil) > ((null entry) (push (list key value) alist)) > (t (push value (cdr entry))))))))))) At first glance, it looks harmless. If the test suite passes, we can apply it. Thank you. Regards, -- Nicolas Goaziou