From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eGq0HQWexV6kWwAA0tVLHw (envelope-from ) for ; Wed, 20 May 2020 21:15:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eDyqGQWexV5IYwAAB5/wlQ (envelope-from ) for ; Wed, 20 May 2020 21:15:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFB769403ED for ; Wed, 20 May 2020 21:15:48 +0000 (UTC) Received: from localhost ([::1]:51366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbW43-0002CB-SL for larch@yhetil.org; Wed, 20 May 2020 17:15:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbW3N-0002BD-Vf for emacs-orgmode@gnu.org; Wed, 20 May 2020 17:15:07 -0400 Received: from ciao.gmane.io ([159.69.161.202]:38702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbW3N-00049l-C4 for emacs-orgmode@gnu.org; Wed, 20 May 2020 17:15:05 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1jbW3J-000Vxd-RY for emacs-orgmode@gnu.org; Wed, 20 May 2020 23:15:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Subject: Setting org-todo-keywords through directory-local variables Date: Wed, 20 May 2020 23:12:47 +0200 Message-ID: <87mu62gvjk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cancel-Lock: sha1:7/3EkcOyHH0Ag+boydJXZ0+FhiQ= Received-SPF: pass client-ip=159.69.161.202; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/20 17:15:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.41 X-TUID: q/kPB17HZSo+ Hello, I'd like to set org-todo-keywords and org-todo-keyword-faces through directory-local variables, to get rid of duplicate #+SEQ_TODO lines in my Org files[1]. Right now I see two obstacles for this to work: (1) org-set-regexps-and-options, which sets up a bunch of TODO-related machinery, insists on using (default-value 'org-todo-keywords), (2) this function is called in the major mode function, which IIUC means that directory-local values have not been applied yet. The first obstacle looks like it can be easily removed[2]; the second obstacle looks more substantial. It is trivially side-stepped by sticking (hack-local-variables) at the top of org-mode; to my untrained eye, it looks like TRT would rather be for Org to add org-set-regexps-and-options to hack-local-variables-hook. This sounds like a risky change though: I imagine that a lot of what happens in the major mode function depends on what org-set-regexps-and-options sets up, and would therefore need to be moved to this hook as well. Figuring which parts should be moved seems like a non-trivial task that might introduce some regressions… Can anyone confirm that this would (in principle) be the way forward, or tell me if I am missing something[3]? Thank you for your time. [1] For example: #+begin_src elisp ((org-mode . ((org-todo-keywords . ((sequence "REPORT" "REPORTED" "WAITING" "FIXED") (sequence "CANCELED"))) (org-todo-keyword-faces . (("REPORT" . org-todo) ("REPORTED" . warning) ("WAITING" . warning) ("FIXED" . org-done) ("CANCELED" . shadow)))))) #+end_src I'd like that so much that I went through the trouble of writing safe-local-variable predicates for these variables: #+begin_src elisp (put 'org-todo-keywords 'safe-local-variable (lambda (x) (cl-every (lambda (seq) (and (memq (car seq) '(sequence type)) (cl-every (lambda (i) (stringp i)) (cdr seq)))) x))) (put 'org-todo-keyword-faces 'safe-local-variable (lambda (x) (cl-every (lambda (pair) (pcase pair (`(,keyword . ,face) (and (stringp keyword) (or (facep face) (listp face)))))) x))) #end_src [2] I tried to go through org.el's history, but I could not find a rationale for using default-value. [3] Alternatively, maybe the answer is as simple as "Org documents should be self-sufficient; keywords should be explicitly set in #+SEQ_TODO lines"; that wouldn't sound right though, since org-todo-keywords is customizable.