From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iGCcES4l114WZQAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 04:21:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wENdDS4l115dKgAAbx9fmQ (envelope-from ) for ; Wed, 03 Jun 2020 04:21:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E9AF94001C for ; Wed, 3 Jun 2020 04:21:01 +0000 (UTC) Received: from localhost ([::1]:59724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgKte-000153-UF for larch@yhetil.org; Wed, 03 Jun 2020 00:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgKt5-00014j-5t for emacs-orgmode@gnu.org; Wed, 03 Jun 2020 00:20:23 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:61437) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgKt3-0006Zo-FN; Wed, 03 Jun 2020 00:20:22 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id F32DF5CD3F; Wed, 3 Jun 2020 00:20:18 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=nwkpqdUvcm9u 21/2et2ZKstqzKY=; b=O3dGeXozV+LdihKYFHmG1tXbgLU9bDnKll+UuSDnuxln e5HgatLDfe1CDDLApR2rm9LEUq3bqA47qFIFfpM2ST8UiHqNJ5e2pjT77yqPkE/o kg0UczI/DtkA+OHK+0PwTFV9iIOnDF3bo7Di4gcPzecGF4qLISDFrEMpCXjMGpE= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id EBE475CD3E; Wed, 3 Jun 2020 00:20:18 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=PEaVSSVTRnwA5aitJkwttGGVdA8b++x+4n4kFADVosk=; b=veot7eBcSoCEuKi5Cbe1xLrDp6Dx6ZxsBHOppn9Zwb7yr6qqcyDMBS15e/wYu+l9dyHoh1Iq+kTAb3FRQu55gvPzwqCDvTmZuz9JdpyW/G+zkJOVGTaMzt/gvIgnI2c7Ouq0RbFfqa0Kl3tFE1YkMMCKCjI1v8I+3eDSZM6jCKQ= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 6DB365CD3D; Wed, 3 Jun 2020 00:20:18 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: Failing tests In-Reply-To: <87r1uyhmfk.fsf@gmail.com> References: <87wo4vv4mt.fsf@kyleam.com> <87imgevrou.fsf@gmail.com> <878sh8vgx3.fsf@kyleam.com> <87r1uyhmfk.fsf@gmail.com> Date: Wed, 03 Jun 2020 04:20:17 +0000 Message-ID: <87mu5kwzjy.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 883A3FDE-A551-11EA-A8B3-C28CBED8090B-24757444!pb-smtp1.pobox.com Received-SPF: pass client-ip=64.147.108.70; envelope-from=kyle@kyleam.com; helo=pb-smtp1.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/03 00:20:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=O3dGeXoz; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=veot7eBc; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: DffkfIduLXkS K=C3=A9vin Le Gouguec writes: > Kyle Meyer writes: > >>> I think I've narrowed this down to org-open-file running "less >>> examples/att1/fileA" instead of visiting this file. >> [...] >>> Let-binding org-file-apps to '(("." . emacs)) makes the tests pass, but >>> I don't know if that's the way we want to solve this. >> >> Thanks for looking into the failures. Let-binding org-file-apps sounds >> like a good approach to me. Rather than the catch-all regular >> expression, I believe the value could be ((t . emacs)). > > Absolutely. I've attached a patch to that effect. Thanks. Applied (c8f7e89d7). > I wonder though, shouldn't org-open-file always visit text/plain files? > Why would we ever want to send those to an external viewer? > > I think this would need special-casing inside org-open-file, since I > don't see a way to catch all text/plain files with org-file-apps. Good question. I'm not sure, though offhand I can't think of cases where I'd want to send text/plain files to an external viewer. I'd guess this doesn't matter much in practice given the default position of (auto-mode . emacs) in org-file-apps, which will catch a good number of text/plain files.