From: Kyle Meyer <firstname.lastname@example.org> To: "Kévin Le Gouguec" <email@example.com> Cc: Bastien <firstname.lastname@example.org>, email@example.com Subject: Re: Failing tests Date: Wed, 03 Jun 2020 04:20:17 +0000 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Kévin Le Gouguec writes: > Kyle Meyer <firstname.lastname@example.org> writes: > >>> I think I've narrowed this down to org-open-file running "less >>> examples/att1/fileA" instead of visiting this file. >> [...] >>> Let-binding org-file-apps to '(("." . emacs)) makes the tests pass, but >>> I don't know if that's the way we want to solve this. >> >> Thanks for looking into the failures. Let-binding org-file-apps sounds >> like a good approach to me. Rather than the catch-all regular >> expression, I believe the value could be ((t . emacs)). > > Absolutely. I've attached a patch to that effect. Thanks. Applied (c8f7e89d7). > I wonder though, shouldn't org-open-file always visit text/plain files? > Why would we ever want to send those to an external viewer? > > I think this would need special-casing inside org-open-file, since I > don't see a way to catch all text/plain files with org-file-apps. Good question. I'm not sure, though offhand I can't think of cases where I'd want to send text/plain files to an external viewer. I'd guess this doesn't matter much in practice given the default position of (auto-mode . emacs) in org-file-apps, which will catch a good number of text/plain files.
next prev parent reply other threads:[~2020-06-03 4:21 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <email@example.com> [not found] ` <firstname.lastname@example.org> 2020-05-27 22:20 ` Possible fix for :includes header argument in org-babel C source blocks Kévin Le Gouguec 2020-05-28 2:30 ` Kyle Meyer 2020-05-28 8:25 ` Kévin Le Gouguec 2020-05-28 10:09 ` Kévin Le Gouguec 2020-05-29 2:47 ` Kyle Meyer 2020-05-29 12:41 ` Failing tests (was: Possible fix for :includes header argument in org-babel C source blocks) Kévin Le Gouguec 2020-05-31 4:59 ` Kyle Meyer 2020-06-01 14:48 ` Failing tests Kévin Le Gouguec 2020-06-01 14:56 ` Kévin Le Gouguec 2020-06-03 4:20 ` Kyle Meyer [this message] 2020-06-01 13:54 ` Bastien 2020-05-29 3:37 ` Possible fix for :includes header argument in org-babel C source blocks Brandon Guttersohn 2020-05-29 9:57 ` Kévin Le Gouguec 2020-05-30 17:29 ` Brandon Guttersohn 2020-06-01 13:55 ` Bastien 2020-06-01 20:17 ` Kévin Le Gouguec 2020-06-02 0:02 ` Brandon Guttersohn 2020-05-29 2:45 ` Kyle Meyer 2020-04-17 23:02 Failing tests Marco Wahl 2020-04-21 3:00 ` Kyle Meyer 2020-04-21 9:32 ` Marco Wahl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Failing tests' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).