emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: emacs-orgmode@gnu.org, "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Subject: Re: [9.4] LOGBOOK visibility
Date: Sat, 04 Jul 2020 10:08:17 +0200	[thread overview]
Message-ID: <87mu4f66tq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r1ts3s8r.fsf@localhost> (Ihor Radchenko's message of "Sat, 04 Jul 2020 10:53:56 +0800")

Hello,

Ihor Radchenko <yantar92@gmail.com> writes:

> There used to be several types of overlays for headline folding, drawer
> folding, and block folding. One of the recent commits made all the
> overlays use headline type. As a result all the overlays are merged into
> a single overlay upon folding. This was done to reduce the total number
> of overlays present in an org buffer, which degrades Emacs performance
> on huge org files (see the discussion in [1]). 
>
> What you observe is a consequence of that change. Now, all the drawer
> overlays are destroyed when you fold a heading. Isearch would
> only see a single huge overlay and unfold it alltogether.

For completeness, at the beginning drawers and outline shared the same
invisibility value. 

At some point during 9.X development, I gave drawers their own
invisibility value. It provided an overall nicer behaviour, but also
introduced some serious slowdown in large files.

Recently, as pointed out by Ihor, I switched drawers back to their
initial state, i.e., they now share the same invisibility value as the
outline. At least, Org on very large files is slightly more manageable,
but the behaviour is less nice. With overlays, you can't have your cake
and eat it too.

> I am currently working on a patch to rewrite the whole folding system.
> Your issue should disappear once it is applied.

Yes, hopefully, switching to text properties will get us out of this sad
situation.

Regards,
-- 
Nicolas Goaziou


  parent reply	other threads:[~2020-07-04  8:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 10:19 Kévin Le Gouguec
2020-07-03 13:47 ` Kévin Le Gouguec
2020-07-03 18:17   ` Kévin Le Gouguec
2020-07-04  2:53     ` Ihor Radchenko
2020-07-04  4:57       ` Ihor Radchenko
2020-07-04  8:03       ` Kévin Le Gouguec
2020-07-04  8:08       ` Nicolas Goaziou [this message]
2020-07-04  8:28         ` Kévin Le Gouguec
2020-07-04 11:18           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu4f66tq.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin.legouguec@gmail.com \
    --cc=yantar92@gmail.com \
    --subject='Re: [9.4] LOGBOOK visibility' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).