emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-read-date: selecting date with mouse-2 in calendar
Date: Fri, 26 Feb 2021 01:28:14 -0500	[thread overview]
Message-ID: <87mtvre41t.fsf@kyleam.com> (raw)
In-Reply-To: <87mtvr5wi3.fsf@web.de>

Michael Heerdegen writes:

> Hello again,
>> selecting a date from within `org-read-date' from the calendar works
>> with mouse-1, but not with mouse-2 (with latest Emacs master and my
>> settings loaded at least).
>> The code seems to intend that it also works with mouse-2, but it fails.
>> Why it doesn't work?  Oh, that's because calendar already binds
>> down-mouse-2 to pop-up a menu (see definition of `calendar-mode-map').
>> So when we would add the following line to `org-read-date' (it's obvious
>> to where and I'm too lazy to create a patch now):
>> +  (org-defkey map [down-mouse-2] nil)
> No comments on this (hope it wasn't too confused...)?

I don't know anything about these mouse things and have to review the
manual whenever they come up.  Please provide a patch with a proper
commit message, and I'll review it this weekend if nobody else gets to
it sooner.

> Should I just commit the fix to the Emacs master branch?

No, I'd appreciate if you did not.

      reply	other threads:[~2021-02-26  6:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14  2:50 org-read-date: selecting date with mouse-2 in calendar Michael Heerdegen
2021-02-14  2:52 ` Michael Heerdegen
2021-02-14  3:36 ` Michael Heerdegen
2021-02-26  3:38 ` Michael Heerdegen
2021-02-26  6:28   ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtvre41t.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael_heerdegen@web.de \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).