From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CbDLDlo0e2CCewEAgWs5BA (envelope-from ) for ; Sat, 17 Apr 2021 21:17:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CApTCVo0e2DnRgAAB5/wlQ (envelope-from ) for ; Sat, 17 Apr 2021 19:17:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A8E3D18C64 for ; Sat, 17 Apr 2021 21:17:45 +0200 (CEST) Received: from localhost ([::1]:45308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXqRs-0006lp-RT for larch@yhetil.org; Sat, 17 Apr 2021 15:17:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXqR6-0006go-4a for emacs-orgmode@gnu.org; Sat, 17 Apr 2021 15:16:56 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:53343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXqQz-0000Zu-M6 for emacs-orgmode@gnu.org; Sat, 17 Apr 2021 15:16:55 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1618687008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3ikG6uswnZ5OqkVgzbUMv7GEekXbdpJsd7T8++4Vrf4=; b=vLO5guMmcLDynWhuWjc2uUCVHwtmiSYoZejfGu0j+3bMQEQmW3k2BboT01GC0SUwo2WESi pWo8WWa01O+zDT4BGkvrMdvd/G1pNruICJ888yKBOlEBV3wHMaJysfFvOeZfq8KkePNmw1 DiqMb7xJQ8s5BLb1fval3gJYF/MMVGgPiSBafeLwej78mzfIxkUtFYR+/QVcqby2ec4vza khZquT1wKEtu/BWub24Aqzxgje9iSIZKyOSM6m+2IHduztTT2rZakAhzVK5sziCraqLEf5 FIsbq8MDLgtBpcPUMO0KyDrlVmOm8fs53dfpuzIcTTSZ7f4eN9f0joszJSAnVQ== From: Kyle Meyer To: Trevor Murphy Subject: Re: [PATCH] org-eldoc: Fix compatibility with eldoc 1.11 and Emacs 27 In-Reply-To: <20210413194014.2150076-1-trevormurphy@google.com> References: <20210413194014.2150076-1-trevormurphy@google.com> X-Woof-Patch: applied Date: Sat, 17 Apr 2021 15:16:47 -0400 Message-ID: <87mttwlo0w.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618687065; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3ikG6uswnZ5OqkVgzbUMv7GEekXbdpJsd7T8++4Vrf4=; b=ZiJ2iiRqoCeLmRkhD5gUAZI11oc0DEbfimHcq1oyYdQy6z1HZiKmCH7dQTElD2i6z2Ab4M uSFkmxI2Cmh5Eo/xF+ChyLDHnWBkjqcy/RPksVhcmH9H5bULeeING0Xy/iT7z/eY5q9LoR 81mHIqlUb0IlAj7GpRxjh7RsQLWsd/0rTviLOFw/Apus6VZpqiNXzV4TzYrHSDG6pP/NEr gkXiIoAt1g8maKpPwfSPTv7Q8INzrRLwG9KDrEtuzOwb9hQHGSR0WBY5JNrG/CqH3C2QLB hqp8ZaT/oVVIRVembn9xjp0JTD26EI0nuoxJI5dhcoNIxXntwQpl9LdKRAmSCg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618687065; a=rsa-sha256; cv=none; b=NnaTvbho8HnTM9mQ+0wv5PAyXHUOSohogCoKyRTI3//8Weg8t+pVSPjNy3MSt9T+Vj/mAj 0HHfK5I2a/JnqiKV6tOA3qF6Wq5F28jNOALrSfNFiIjl1YQ21gmvgvijwvqQ5FTvk13/LX qnT33zBZkRqMFp98IBsEGPZsc5G97x36T2kE8kN6nh0nxJ6yz8z/fvgRFI2jpUeJTGgAav 630uHgKj2UCALM6F63TEZb/KL9kpU50I3XhRshx5R3OCGpfQ+Ee90pI5gSKCZFKUHG7kc9 yeCodtIuv63E786jiqqMs8az5YTuirj1dbKwKxvx7DtdXjHvA8gPk8gjdb/BVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=vLO5guMm; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.14 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=vLO5guMm; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A8E3D18C64 X-Spam-Score: -1.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: CbSPM8oUq4aZ Trevor Murphy writes: > * contrib/lisp/org-eldoc.el (org-eldoc-documentation-function): Check > before invoking elisp eldoc functions from Emacs 28. > > The previous check assumed that the presence of eldoc 1.11 bindings > implied elisp-mode bindings that come with Emacs>=28, but eldoc 1.11 > is available on GNU Elpa so the assumption doesn't always hold. Thanks. Pushed (7e2eba8cc).