From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iB/9FEaKZmKUegAAbAwnHQ (envelope-from ) for ; Mon, 25 Apr 2022 13:47:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KFy3FEaKZmIwDwAAauVa8A (envelope-from ) for ; Mon, 25 Apr 2022 13:47:18 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1131419999 for ; Mon, 25 Apr 2022 13:47:17 +0200 (CEST) Received: from localhost ([::1]:36466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nixBU-0002Vq-L9 for larch@yhetil.org; Mon, 25 Apr 2022 07:47:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nix8z-00018A-Hp for emacs-orgmode@gnu.org; Mon, 25 Apr 2022 07:44:41 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:43882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nix8x-00012s-GM for emacs-orgmode@gnu.org; Mon, 25 Apr 2022 07:44:41 -0400 Received: by mail-pl1-x631.google.com with SMTP id d15so26388527pll.10 for ; Mon, 25 Apr 2022 04:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=nsYp51vbIfhYnOWfsJ2QT6UI/pcKDKdrVtu8IWquixzG5yLpblSuIh7WmFWFHfbKhQ Tfnrxyr66PciuR6bWaoJhfuTAOBqnBguStXn94R71CJ+xq6Aiicp85kUEnwpF+YwzTHC iL4rsWFcAOhKmo4prMR7Sii8PZc4NG0tHO5wevZFXBDqrYUHLmHRx2s1SWQLd31aHEls ALWSM8l6eiZCSVhkenC7ZXGnMWDeSTwH8XEBPBxZhMZm5rXy/Uy60/XGB/8dOXF8woiH f0y4IwehFbgEaWpnrQAqZG++/lXYJ+34+Mb+rvWoFdxEMoSRqkVXOv1XBUZYGu3SsFBW 0VxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=aVDdMXsrv9ZnUus8zKAnyTZArqLj9RZn6YFvOZKwgF73bgfFBRAr0vLJHvhncAbQ3D W7CixBhQ2MeQ2trLI9cBz6gwENG8Glh362/ENxcBDz7+4Oun6S5qHZr9Z9qr2uNDRXb+ 83KxNGaApkxdRby58W80Ts1rYsULKmT0zO+rx6cbOtEVUg0cyDzpGQqQtETwnHXm3fha lmf3gRpoaxx5SuTBq3b/oeF508KUHXhuEJIujx3xrS3B39ialqy0D3RcwMkEaMDQ3n6X EYGT2M4wXl5FGzZOUITo7mx5XqBXGAzCI2vk28eJ2H97OLKcaLw/8ttR+q7eQiqxdcte xSRA== X-Gm-Message-State: AOAM532yYzgRQY29zMTy7JfOGpT//zrZqCM0y/vzti5vZE7A+myBmH6k OiDG4pClXzy8OaI0G3iBhOczSxyjbg8WAcTH X-Google-Smtp-Source: ABdhPJzHMEILVk3vfJgd8/lj/L+44d1r5f3LuFySJGpZVrQ8C4gAuty9656plxOegDxvovzbq6Fw7Q== X-Received: by 2002:a17:90a:ab81:b0:1ca:8a76:cdda with SMTP id n1-20020a17090aab8100b001ca8a76cddamr30858322pjq.26.1650887078207; Mon, 25 Apr 2022 04:44:38 -0700 (PDT) Received: from localhost ([63.143.61.57]) by smtp.gmail.com with ESMTPSA id b23-20020a17090ae39700b001cd4989ff61sm11053402pjz.40.2022.04.25.04.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 04:44:37 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch In-Reply-To: <8735i5gd8n.fsf@gmail.com> References: <87a6f84edg.fsf@localhost> <8735i5gd8n.fsf@gmail.com> Date: Mon, 25 Apr 2022 19:45:30 +0800 Message-ID: <87mtg9v12d.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=yantar92@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650887238; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Tugvo32b6lC0IAvmDDCsEoBBOikV8k0Rs1pp7HzTGXc=; b=rnAsuQSjnbdssKXA8XHx5aE3YmRUVG4GfUC+dzPZgPRQM11Mytd5EmAxzcFJxisbBL/AcD yCVwuov+eQcj9D6TR8lvjEIuoR/xoj/KMrilmwHga4dB9n+S2jxpFZn2RQY23JgjHDdOva ObvS+kpDXmOePeFW+tCu5Fhr+5orcIlvScMyBSPJvjU1WtWfp2sFbvFLeMth+/YwN+U+nB 0vekWnyphRsVCYg74KxxpQ6svaJlpoxKjK/mwHqSubxTYWtER/JfdIn0Luw7y6i3e2aOfi RfzBnKJoblmRgo5tSpTkpDoGMdxaTMaPI/taVnsNsMLSlFCkqWuMHpWUYgRYnA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650887238; a=rsa-sha256; cv=none; b=ANCa9+60HxXlWPQaigwSM/t07cVnO9GmJYeJ2B+jE0Txhvz1IFwI48a6NW8Lc1+UVGjyqN RgOa0vbhmzsQWKxjTpqO0TkPepX0UOtfVDn48UeunnF8V4g37deAtu8gFwlyb9LjRaSscG LGK2flCwj5O1Ivvs+KfE3I79uVNqS5q3+JlDrswnUpWtdYG/mZwfUBQnnEUJrW3Ee5lBYr lNXN1f5rDUtzkQXqE25rSol2Tf6JeBxl2qqUOKc0QjM3v3ApKUiZAz8dNwgeMvTnHGgKmf KXOb24ylr9kAQTV+89+g9VRBNj//2N94JTYpB1viRFnQwSTN4JyfDWItj3KSPQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nsYp51vb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nsYp51vb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 1131419999 X-Spam-Score: -3.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: kjoOT7nDrXe/ I think I addressed the raised issues. Just merged org-fold upstream. K=C3=A9vin Le Gouguec writes: > My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): > > $ git switch feature/org-fold-universal-core-tidy > $ make autoloads > $ emacs -Q -L lisp -eval "(setq org-startup-folded t)" repro.org > > Restarting Emacs with the above between each step: > > (1) C-s abc =E2=87=92 no logbook is unfolded, > (2) C-s def =E2=87=92 no logbook is unfolded, > (3) C-s ghi =E2=87=92 some logbooks are unfolded. > > Assuming you can reproduce: is it expected that logbooks are expanded in > case (3)? I don't see what's "conceptually" different in situation (3) > vs. (1) and (2), so I'm puzzled to get different results. I had a hard time to reproduce your recipe because it was related to font-locking. The only way was increasing the font size, so that line widths were larger than the frame width. I believe I fixed the issue now. > Also, a bit of idle curiosity: > >> (defun org-fold--isearch-reveal (&rest _) >> "Reveal text at POS found by isearch." >> (org-fold-show-set-visibility 'isearch)) > > org-fold-show-set-visibility calls either > org-fold-show-set-visibility--overlays, or > org-fold-show-set-visibility--text-properties, and AFAICT neither of > these handle 'isearch as an argument=E2=80=A6 Is there a (cdr (assq 'ise= arch > org-fold-show-context-detail)) missing? > > (This comes from a very cursory reading of the code; apologies if I've > missed something) You are right. I supposed to use org-fold-show-context. Fixed now. Best, Ihor