Hi, While doing some stuff with org-mode, I noticed the error message "Could not read ‘org-id-values’ from ~/.emacs.d/whatever, setting it to nil". I quicly understood it’s related to org-id, but the only occurence I found for ‘org-id-values’ was in that exact error message. I wonder if this is not a little typo and the error message should speak of ‘ord-id-locations’ instead? This patch fix that problem. I’ve signed the GNU paper to make patch to GNU project if it matters. I can send a copy of it to anyone if needed. As this is my first contribution, I hope I do it well. Have a nice day, Étienne Signed-off-by: Étienne Deparis <etienne@depar.is> --- lisp/org-id.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-id.el b/lisp/org-id.el index 13a831590..f54e7280a 100644 --- a/lisp/org-id.el +++ b/lisp/org-id.el @@ -595,7 +595,7 @@ If SILENT is non-nil, messages are suppressed." (setf (car item) (expand-file-name (car item) loc)))) org-id-locations))) (error - (message "Could not read `org-id-values' from %s, setting it to nil" + (message "Could not read `org-id-locations' from %s, setting it to nil" org-id-locations-file)))) (setq org-id-files (mapcar 'car org-id-locations)) (setq org-id-locations (org-id-alist-to-hash org-id-locations)))) -- 2.37.1
Étienne Deparis <etienne@depar.is> writes: > This patch fix that problem. Thanks for your contribution! Applied onto main via 79dfb16d5 with amendments to the commit message to follow our conventions. You may refer to https://orgmode.org/worg/org-contribute.html for future patches. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=79dfb16d52815e4332b896216e83a7ac882faf61 > I’ve signed the GNU paper to make patch to GNU project if it matters. I can > send a copy of it to anyone if needed. Bastien, can you please confirm that Étienne is listed in the GNU copyright records? Best, Ihor
Hi Ihor and Etienne, Ihor Radchenko <yantar92@gmail.com> writes: > Bastien, can you please confirm that Étienne is listed in the GNU > copyright records? Yes, I confirm, I added Etienne on the list of FSF-signed contributors on https://orgmode.org/worg/contributors.html. Thanks! -- Bastien
Thank you very much for the quick review! I’m glad it was not an
error
of mine and it will help others.
mer. 03 août 2022 à 12:04, yantar92@gmail.com a écrit :
> Applied onto main via 79dfb16d5 with amendments to the commit
> message to
> follow our conventions. You may refer to
> https://orgmode.org/worg/org-contribute.html for future patches.
I’m sorry I did not take time to fully cover it before sending my
patch. I will better read it for next time.
Best,
Étienne