* [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message
@ 2022-08-02 14:35 Étienne Deparis
2022-08-03 10:04 ` Ihor Radchenko
0 siblings, 1 reply; 4+ messages in thread
From: Étienne Deparis @ 2022-08-02 14:35 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Étienne Deparis
Hi,
While doing some stuff with org-mode, I noticed the error message "Could
not read ‘org-id-values’ from ~/.emacs.d/whatever, setting it to nil".
I quicly understood it’s related to org-id, but the only occurence I
found for ‘org-id-values’ was in that exact error message.
I wonder if this is not a little typo and the error message should speak
of ‘ord-id-locations’ instead?
This patch fix that problem.
I’ve signed the GNU paper to make patch to GNU project if it matters. I can
send a copy of it to anyone if needed.
As this is my first contribution, I hope I do it well.
Have a nice day,
Étienne
Signed-off-by: Étienne Deparis <etienne@depar.is>
---
lisp/org-id.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-id.el b/lisp/org-id.el
index 13a831590..f54e7280a 100644
--- a/lisp/org-id.el
+++ b/lisp/org-id.el
@@ -595,7 +595,7 @@ If SILENT is non-nil, messages are suppressed."
(setf (car item) (expand-file-name (car item) loc))))
org-id-locations)))
(error
- (message "Could not read `org-id-values' from %s, setting it to nil"
+ (message "Could not read `org-id-locations' from %s, setting it to nil"
org-id-locations-file))))
(setq org-id-files (mapcar 'car org-id-locations))
(setq org-id-locations (org-id-alist-to-hash org-id-locations))))
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message
2022-08-02 14:35 [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message Étienne Deparis
@ 2022-08-03 10:04 ` Ihor Radchenko
2022-08-03 11:29 ` Bastien Guerry
2022-08-03 14:52 ` Étienne Deparis
0 siblings, 2 replies; 4+ messages in thread
From: Ihor Radchenko @ 2022-08-03 10:04 UTC (permalink / raw)
To: Étienne Deparis, Bastien; +Cc: emacs-orgmode
Étienne Deparis <etienne@depar.is> writes:
> This patch fix that problem.
Thanks for your contribution!
Applied onto main via 79dfb16d5 with amendments to the commit message to
follow our conventions. You may refer to
https://orgmode.org/worg/org-contribute.html for future patches.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=79dfb16d52815e4332b896216e83a7ac882faf61
> I’ve signed the GNU paper to make patch to GNU project if it matters. I can
> send a copy of it to anyone if needed.
Bastien, can you please confirm that Étienne is listed in the GNU
copyright records?
Best,
Ihor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message
2022-08-03 10:04 ` Ihor Radchenko
@ 2022-08-03 11:29 ` Bastien Guerry
2022-08-03 14:52 ` Étienne Deparis
1 sibling, 0 replies; 4+ messages in thread
From: Bastien Guerry @ 2022-08-03 11:29 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Étienne Deparis, emacs-orgmode
Hi Ihor and Etienne,
Ihor Radchenko <yantar92@gmail.com> writes:
> Bastien, can you please confirm that Étienne is listed in the GNU
> copyright records?
Yes, I confirm, I added Etienne on the list of FSF-signed contributors
on https://orgmode.org/worg/contributors.html.
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message
2022-08-03 10:04 ` Ihor Radchenko
2022-08-03 11:29 ` Bastien Guerry
@ 2022-08-03 14:52 ` Étienne Deparis
1 sibling, 0 replies; 4+ messages in thread
From: Étienne Deparis @ 2022-08-03 14:52 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Thank you very much for the quick review! I’m glad it was not an
error
of mine and it will help others.
mer. 03 août 2022 à 12:04, yantar92@gmail.com a écrit :
> Applied onto main via 79dfb16d5 with amendments to the commit
> message to
> follow our conventions. You may refer to
> https://orgmode.org/worg/org-contribute.html for future patches.
I’m sorry I did not take time to fully cover it before sending my
patch. I will better read it for next time.
Best,
Étienne
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-03 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-02 14:35 [PATCH] org-id: Fix ‘org-id-locations’ variable name in error message Étienne Deparis
2022-08-03 10:04 ` Ihor Radchenko
2022-08-03 11:29 ` Bastien Guerry
2022-08-03 14:52 ` Étienne Deparis
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).