From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mPegKZ0LYmNPPwEAbAwnHQ (envelope-from ) for ; Wed, 02 Nov 2022 07:18:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oIuWKZ0LYmPMXAAAauVa8A (envelope-from ) for ; Wed, 02 Nov 2022 07:18:05 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 46E02D0B8 for ; Wed, 2 Nov 2022 07:18:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oq73V-0006Mz-TL; Wed, 02 Nov 2022 02:16:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq73Q-0006KZ-QV for emacs-orgmode@gnu.org; Wed, 02 Nov 2022 02:16:51 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq73O-00037t-La for emacs-orgmode@gnu.org; Wed, 02 Nov 2022 02:16:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 98BFB240026 for ; Wed, 2 Nov 2022 07:16:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667369804; bh=m1vQXIdREoSmrqeFvCVcSGk7LoOPbJNrMne1jmQx1dA=; h=From:To:Cc:Subject:Date:From; b=L66KPlODcJHuu/istSIG3+t6qsB3TInMUFJKZfFl3/tg91agNajhfkr2fTu2vOdFh euFdSxbvXJRG12Z4Qj8mGvCDN8h+IfVWJChLamfJ01hSa78PD/2mm3Z0QJAUJbzWBV wF71Q0Tx3R+evDDvrWS3tab4N99YFXT5/xSDFZeW5UzJqKvOK5y6YOxCntd/PcgCAd IrRuUVVikI5tbw56nQH9f2vXTGv1ruSomZOtUUs44KTryDg67QWu77/Ls7j+rLyFeh csPnR2FcPDJE3ZHBNacWagYPvCb4doewHX7JXOfaopTgDXamPE8PzvVWb4yyoFBy+r /mr2+N7BnAn8Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N2Gqr5W23z9rxG; Wed, 2 Nov 2022 07:16:40 +0100 (CET) From: Ihor Radchenko To: Daniel Ziltener Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option In-Reply-To: References: <20221026193733.14725-1-dziltener@lyrion.ch> <87o7twn101.fsf@localhost> <87zgdfjnko.fsf@localhost> <8735b6ar1q.fsf@localhost> Date: Wed, 02 Nov 2022 06:17:17 +0000 Message-ID: <87mt99lw2a.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667369885; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f6r2MB9tDuBg+ta1KcoGhGyb7uNTEo0xUX2Hdg3GGco=; b=IczeGrPLC4N9cUcxTGC9yPXQLcLcfw6vTgJZvFLO6tHUvLEVyb64k2S4JW2SWoAk6EtmK8 djQJmgUxoPprfzAfJeVF69GDwgAgrfKmZUhSUeU+ZbRrYJ5WDSISeDWvhiVxyapwmDkQg8 PKp981vf7uEdjuXgpreA8kQRqsVsq3sKCoLvy7zhKlG0KbGjPNI+vz9kfJHYH7hKvb8q4f Y4DljCdTLC+EM/c2mD/QVyPe32Yaf/a+LgvPqjJ8fQhhBWcKWd95yzTObUbxbOmptaFchR vbFg9goOFFnOzVE/yVoCu/C5Pf1DCXBFHZIyqIX5TLLilBirffFPc+/ejwX3Xw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667369885; a=rsa-sha256; cv=none; b=qVI3xqm0gnT/riKFHqREE7heSjdtjXCmcYOS8vApx5jOttVffusVUGAPN2/YiXNjgGz2om WYHqkdGlXdVvD+/6FXbY/ssAVWu+rqBYikDLrgJ089YXX6N1wa0vAaODsIXVEHthAOBxoJ PbnGc/SC0o07X1XNqFWf1DDAxpFy8Ua7LMMKBrR5jYkxre+UFPPP+lz4mXZsiqkUf/nz6g ICvarBQnFq+Z7E7VCZXx9n3fiaN7XQGOvVfvRl05OgypCMI+E/igEzhpygW2rA6+xMoGZy 3dASiM6LB2siUY+a9NzY5l8wFl+t9/jbQYyV4OfyENIqsVgsAllYLxDdRLnILw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=L66KPlOD; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.48 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=L66KPlOD; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 46E02D0B8 X-Spam-Score: -3.48 X-Migadu-Scanner: scn1.migadu.com X-TUID: hezHMbkzlIZK Daniel Ziltener writes: >> Could you please create a separate patch file and attach it in the >> reply? > Sure, here's the patch attached, as generated by "git format-patch > origin/main". Thanks! I tried to apply your patch and run tests. The new test for "strip-tangle" is failing on my side. Also, several small comments about the commit message. > * lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags > from block if :noweb has been set to strip-tangle. > * lisp/ob-core.el (org-babel-common-header-args-w-values): add > "strip-tangle" as new allowed value. > * testing/lisp/test-ob-tangle.el (ob-tangle/strip-tangle): add new test > case for strip-tangle. > * doc/org-manual.org (Noweb Reference Syntax): adjust documentation for > the noweb header argument. > * etc/ORG-NEWS: add entry for new header argument value. Please start sentences with capital letter. Also, use "strip-tangle" or strip-tangle consistently. > This patch adds the "strip-tangle" option for the :noweb header > argument. This strips the noweb tags before tangling the block. This can ^" " We use double space between sentences in commit messages as well. Not only in the documentation. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at