From: Ihor Radchenko <yantar92@posteo.net>
To: Brian Powell <powellb@hawaii.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] commit 7048876f broke Figure link with caption [9.6 (release_9.6 @ /Users/powellb/src/org-mode/lisp/)]
Date: Wed, 21 Dec 2022 12:36:12 +0000 [thread overview]
Message-ID: <87mt7hvsqr.fsf@localhost> (raw)
In-Reply-To: <m2tu1s458q.fsf@hawaii.edu>
Brian Powell <powellb@hawaii.edu> writes:
> It seems that the following commit broke the ability to link to a figure
> with a caption.
>
> commit 7048876f6fa519513763c83bc5baa791420cddab
> Author: Ihor Radchenko <yantar92@posteo.net>
> Date: Tue Dec 13 11:44:22 2022 +0300
>
> org-export-get-ordinal: Do not ignore ELEMENT type when TYPES is given
>
> * lisp/ox.el (org-export-get-ordinal): Append ELEMENT type to TYPES,
> when TYPES is non-nil.
>
> I have a simple file with a figure and image link. The figure has a
> #+name and #+caption. If I add a link to the figure name in the
> document, then exporting to HTML fails. Prior commits did not have any issue.
Thanks for reporting!
I was unable to reproduce the problem with the given recipe, but I do
see what is wrong looking at the backtrace.
Fixed on bugfix now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=db34a7d83
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2022-12-21 12:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 0:15 [BUG] commit 7048876f broke Figure link with caption [9.6 (release_9.6 @ /Users/powellb/src/org-mode/lisp/)] Brian Powell
2022-12-21 12:36 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt7hvsqr.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=powellb@hawaii.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).