From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ePd9A+45HGS0TAEASxT56A (envelope-from ) for ; Thu, 23 Mar 2023 12:37:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6FuMAu45HGSCwAAAG6o9tA (envelope-from ) for ; Thu, 23 Mar 2023 12:37:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9013375E8 for ; Thu, 23 Mar 2023 12:37:17 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=A9NqHy7Z; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679571437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=r5HZ3jqneKffLbBThe7VouwiH70LwzurrfAeggMf760=; b=st+Nsa916wbcU/YQD6nqI4xlMXVChCkbxH1UZHhY6BTEAZoI05oTTQRVHOBBh3o+QGg0aH 6+JXCVKSX9GBnLbdlO7boN2TPxJhOwVocYVuvKrtXZwb8OAWuQNsnD5dgqg9AkHoHtxSvO Jo/4L6nkM1NEPExcAVogakhU1x3hiYwyrlb7WZWsENGonKL9kqvHSazZJ8DtlHtdptfMf0 FJ1g74mMjKNfzOBRgeClXt9+9HMWDXiUWPMYXon8mQW1K07+qAQ9EEFwr6pmMiPZQ1bIXB iuJgbpMssHxyrHV5lyLxFmw9WZOKQp0Zy9JBSJexjYb8IGIf/ArOyPKh6x3zyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679571437; a=rsa-sha256; cv=none; b=Sl/mG7vNxzL8NDGjC7JvzAysA94gQOJn5NbO7jhOdLAkltIJONcGFG1oi6rG4EGRle4prj q0iKGUbfFQZodhWOV067Av9l2kZWdyAFkEiaiX9Z3RN/26Wnk7JAadqYOIfS1T8GllLHa+ fh/IkgxnWCIT8syt7Inmknd8h7ww9IPy00+LEES/4jsU0wTgbR/3aHRkRier00EIy1F9me LBAojh9w9QjcCHV3P0EOBzStxFsNL/siWBCu2eRSa8ADp2wjsK8ufJtzMIJvlRzI+GQQHa upF1AQBjj5w2e+eHCV9pg74oETUofcuBmKgqLGSstPdOnqtu6igZY2oJcD2i1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=A9NqHy7Z; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfJF6-0000qy-V7; Thu, 23 Mar 2023 07:36:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfJF4-0000qT-7p for emacs-orgmode@gnu.org; Thu, 23 Mar 2023 07:36:26 -0400 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pfJF2-0005Zo-Bu for emacs-orgmode@gnu.org; Thu, 23 Mar 2023 07:36:25 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Pj3FR4m6rz9sTD; Thu, 23 Mar 2023 12:36:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kraus.my; s=MBO0001; t=1679571371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5HZ3jqneKffLbBThe7VouwiH70LwzurrfAeggMf760=; b=A9NqHy7ZjySPrj1g695B4k1rLc5QweLEdDxsZrBSwkIAUb+x6QGk3ohjlb5NZjjLH04t+h noPEACeS6/+6e8QVxdP0Yv8ayg+18JnUXL4QLJE241Nvxyox60jfJDMop1tWynT6Am8vO3 ZreiQGGxA//WaujNARWRQ2ODng0APicSBdHUYINy7caFuuTUdBO32Ki0JeMtwJx8YHwE3L jeMKpyWPYpi9ypH9H3u+EwM1t1izfdcNlFoexpkICrFvorxK7i6bEmn0XLS1HZV0euh/mX k/bGB4Hsv8+edbUOhbft/oxVAwia6r2AQhActdwLAItI5CBkczIEBiNdzTJZUg== References: <87mt4m53qj.fsf@kraus.my> <87pm9gyebl.fsf@localhost> <877cvkhh9d.fsf@kraus.my> <874jqno6hw.fsf@localhost> <873567h2kk.fsf@kraus.my> <87y1nzflur.fsf@kraus.my> <87v8j2qpsq.fsf@localhost> <87ttymfe9i.fsf@kraus.my> <87y1nxt2v2.fsf@localhost> <87edplyxj5.fsf@localhost> <87zg88eaib.fsf@kraus.my> <877cv9oye2.fsf@localhost> From: Daniel Kraus To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: [patch] ob-clojure: Fix results output Date: Thu, 23 Mar 2023 12:31:56 +0100 In-reply-to: <877cv9oye2.fsf@localhost> Message-ID: <87mt43em3k.fsf@kraus.my> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4Pj3FR4m6rz9sTD Received-SPF: none client-ip=2001:67c:2050:0:465::101; envelope-from=daniel@kraus.my; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: A9013375E8 X-Spam-Score: -6.01 X-Migadu-Spam-Score: -6.01 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: XpoONvRPN12w Ihor Radchenko writes: > Now, the docstring appears to be a bit confusing: > > (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p) > "Evaluate EXPANDED code block with PARAMS using cider. > When CLJS-P is non-nil, use a cljs connection instead of clj." > > It would be useful to mention that PARAMS argument is unused. Should I go with your initial suggestion and just replace it with _? Like (defun ob-clojure-eval-with-cider (expanded _ &optional cljs-p) "Evaluate EXPANDED code block using cider. When CLJS-P is non-nil, use a cljs connection instead of clj." But then someone will maybe wonder why there is unused argument? Or rather something like: (defun ob-clojure-eval-with-cider (expanded _params &optional cljs-p) "Evaluate EXPANDED code block using cider. When CLJS-P is non-nil, use a cljs connection instead of clj. The PARAMS from Babel are not used in this function." Writing good docstrings is hard :D Cheers, Daniel