From: Ihor Radchenko <yantar92@posteo.net>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: Emacs orgmode <emacs-orgmode@gnu.org>
Subject: Re: [BUG] LANG=fr_FR.UTF-8 org-clock "not at timestamp"
Date: Mon, 24 Apr 2023 09:56:46 +0000 [thread overview]
Message-ID: <87mt2xtxgh.fsf@localhost> (raw)
In-Reply-To: <sdvfs8qsz0y.fsf@netyu.xyz>
Ruijie Yu via "General discussions about Org-mode."
<emacs-orgmode@gnu.org> writes:
> I am investigating test failures with LANG=fr_FR.UTF-8 amongst some
> other locales. I noticed that the test
> `test-org-clok/org-clock-timestamps-change' in
> testing/lisp/test-org-clock.el around line 92 failed with "not at
> timestamp", which I presume reveals a genuine bug.
>
> To simplify, here is a reproducer:
>
> --8<---------------cut here---------------start------------->8---
> (require 'org-clock)
> (with-temp-buffer
> (org-mode)
> (insert "CLOCK: [2023-02-19 Sun 22:30]--[2023-02-20 Mon 00:35] => 2:05")
> (goto-char 25) ; 2|2:30
> (org-clock-timestamps-change 'down 1))
> --8<---------------cut here---------------end--------------->8---
Confirmed.
> The error appears: "Not at timestamp". I think it is due to the "." in
> French day-of-week words, such as "dim.", "lun.", etc. Something must
> not be expecting punctuations in that place.
Nope. It is because the total length of the timestamp changes.
`org-clock-timestamps-change' records buffer positions before changing
the timestamps and when the timestamp changes in length, positions may
no longer be accurate. In your reproducer, begts2 points one char before
the actual timestamp upon modification and thus the logic fails.
Note that we cannot use markers here because `org-timestamp-up'/down use
`replace-match' that shuffles the markers around. (see FIXME in
`org-timestamp-change').
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2023-04-24 9:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 9:42 [BUG] LANG=fr_FR.UTF-8 org-clock "not at timestamp" Ruijie Yu via General discussions about Org-mode.
2023-04-24 9:56 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt2xtxgh.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).