From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id yLauCdoYJWbUtwAA62LTzQ:P1 (envelope-from ) for ; Sun, 21 Apr 2024 15:47:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yLauCdoYJWbUtwAA62LTzQ (envelope-from ) for ; Sun, 21 Apr 2024 15:47:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XpkdGr63; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713707226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZrLfWyl9v5W+clLUSZXFy3NtGzrqbVkL0KEd/n1TJYI=; b=ckPWOiAYivaNqLcahzqyGgj3Kxm/CO7WMrvV+Op+aAohYir6vSZQpqFaX7zDGtx/Biw7/5 ci9cLLEbV7d5XrC+WiOCQHrbjfnyBzF6IE77TJh4Kus223DQ+RiJqGWxtoQW4wrf3v2dSK q/1Cx/b2pzwFr62DyrNzqG8y7i0fm6H8u128vufDyUKVItcDIMyF5556sbVmUQ2TXFF31J nP5Ukpcazhpm3zWymhsnacF4i1tq4+8efPhNQQxWTuxTcoj7tupyoQ1rCT9A6A/4vezY21 JIHuBT9dLs5LFDARYornMvojlbOC/LsIgH80L5ch3vK8oOEXKGuZXIUsVEPm8g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713707226; a=rsa-sha256; cv=none; b=GXEmf7QZBK71UeVkGt709hrainegBdZqQWz9356SgP7atJpFRC2lKIOqEdlL60qbW3kIVf vdFZ7smBzrIE6CuMlM+BwwjrRDy8a18QgBg/BjI+GOs2sDQkz+OHtm7ir2Z3lMKkqRtd4W 4LMZ+cGM75xNZ1HL/YWvl/heVT4lJIHTZXRulWyOYunqQeYBtizUYyAZnkbmRi2W5kNjkr I/MlT4mdNfkKu3tOz5iaoV3W2OUK+JyVwz9fHIT/DY+wMeSE1Z0w6Km/DOw/4KtewwB/Bt ttCFG3fqSzNdXCOYKGISc4gLc1B7keQWFm6Rqxmiggk/mJJRMmxmgSTATtdE0Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=XpkdGr63; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E99F612AC8 for ; Sun, 21 Apr 2024 15:47:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryXRe-0004b0-KD; Sun, 21 Apr 2024 09:41:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryXRc-0004Zq-Sq for emacs-orgmode@gnu.org; Sun, 21 Apr 2024 09:41:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryXRa-0002yL-Ol for emacs-orgmode@gnu.org; Sun, 21 Apr 2024 09:41:24 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C6499240105 for ; Sun, 21 Apr 2024 15:41:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713706880; bh=YdDmQXEeZJsQhhPZvO6K1eWbaJendS1UK8eSM2tevbs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=XpkdGr63y7CeYG1tv9xbVrn9yr57DTHFNoKWSX8BgKNVd/xva3ijDcxqov7nVXUuH bERjiT6MD79YsbcXxL8KXQE+28P7kZ8nIfgkY18WnZDmy6XRXJu3wm9JQ5IhNU6zgv Sh8sr1SmI7h1LghkM653KQxuf2GAiTz8d/jqHyDsMqGSlwWjlydqMSOjn4oNsOspFv qv8vZcEf2h968eQ21KruFB4OgzYx7Iw8syUdKpOLpKyVQJOFTXVMUpUEkQQcPWOBBW xAeB5kjp/zHXw170s6q2EJSWsWHPa139DYqsdp94yH7VmEAwW2SK6vJt+W97IrOdJb VGk4YCL4WylEQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VMqKW3fP5z6tw5; Sun, 21 Apr 2024 15:41:19 +0200 (CEST) From: Ihor Radchenko To: Alexander Adolf Cc: emacs-orgmode@gnu.org Subject: Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM In-Reply-To: <98f04a910f31ff9ab38e2ddf9e7f2f5c@condition-alpha.com> References: <486d2b818b62c71b3f307305c06c4318@condition-alpha.com> <871q7cypxl.fsf@localhost> <00aa9bf72dc93f6554bdd236fdfba192@condition-alpha.com> <87y19hbb05.fsf@localhost> <8b72386d118136210f27b553f0a13066@condition-alpha.com> <87cyqtyzgt.fsf@localhost> <91dfeb0fed1a1fe0564e5eb9b95a409d@condition-alpha.com> <87a5lpeiey.fsf@localhost> <87zftp6zz3.fsf@localhost> <98f04a910f31ff9ab38e2ddf9e7f2f5c@condition-alpha.com> Date: Sun, 21 Apr 2024 13:42:09 +0000 Message-ID: <87mspmq1ce.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.64 X-Spam-Score: -6.64 X-Migadu-Queue-Id: E99F612AC8 X-Migadu-Scanner: mx13.migadu.com X-TUID: gCP5qM2VmgeS Alexander Adolf writes: > Ah, `org-column--clean-item'; well spotted! > > Two observations: > > 1) As is now, I'm generating the links in the data collection function > `org-columns--capture-view'. As `org-column--clean-item' is called > from code that runs after the data collection, > `org-column--clean-item' was probably never designed to be able to > handle strings containing links. That it still did sort of "the right > thing" seems more luck than anything else? There is a difference between what `org-columns--clean-item' does and stripping link paths. `org-columns--clean-item' is cleaning up the results for insertion into a table specifically. This is only meaningful in dynamic block, but not in the traditional column view where nothing is actually written to buffer - the columns are displayed on top of the existing headings. Calling `org-columns--clean-item' is a must to create a valid table. In contrast, the purpose of `org-link-display-format' is purely visual - to not make the collected titles way too long. Also, it has no effect when there is a custom `org-columns-modify-value-for-display-function' (see `org-columns--displayed-value'). > 2) Considering what happens when I do `org-store-link' and > `org-insert-link', it would seem more advisable to: > > a) move the link generation to the new formatting function > (re-removing it from `org-columns--capture-view'); > > b) pass the "cleaned" string to `org-link-make-string' as both, the > link and the description parameter. I do not recall seeing `org-store-link' in the patches you submitted. So, I am not sure what you are talking about. May you elaborate? >> We should probably also change org-clock to use >> `org-columns--clean-item'. >> [...] > > As a separate patch, or as a third commit to the patch we are discussing > now? Up to you. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at