emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Christian Egli <christian.egli@sbs.ch>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Support for more flexible effort specifications in TaskJuggler exporter
Date: Wed, 08 Jun 2011 17:27:47 +0200	[thread overview]
Message-ID: <87lixcfimk.fsf@sbs.ch> (raw)
In-Reply-To: 4DE7346B.5010702@hickinbottom.com

Hi Stuart

Stuart Hickinbottom <stuart@hickinbottom.com> writes:

> I've been experimenting with tracking medium-sized tasks in org as a
> work-breakdown and exporting to TaskJuggler to see just how many
> evenings and weekends I'll have to work to meet my promised deadlines! A
> recent patch (patch 638, 6th Match 2011) added support for more flexible
> effort estimate properties such as 4h, 3.5d etc.
>
> Unfortunately, at the moment the TaskJuggler exporter is more fussy over
> this property and only accepts HH:MM or an integer, both of which it
> translates to a number of days when exporting.
>
> The attached patch adds support for passing-through effort
> specifications when they're in the form "REAL UNIT" as they are for TJ,
> supporting the suffixes d, w, m and y in a consistent way to org.
> Support for HH:MM or bare number of days should still work as before. It
> also cleans up another couple of things about the export of effort:
>
> - HH:MM produces a floating point days duration now (was previously
> rounded to an integer)
> - The bare REAL effort regex failed to escape the decimal point (and
> would match any char)
> - Regexes now anchor to the string start to avoid matching the end of
> duff values
> - Docstring updated for more flexible effort specification

Thanks for your patch. I just pushed a patch along the lines of yours
which uses the built-in facilities of orgmode. It handles all effort
durations that are defined in `org-duration-string-to-minutes'. This
brings it in line with the rest of orgmode's effort handling. It also
fixes the documentation in org.texi.

Can you check and see if this fixes all your issues?

Thanks
Christian
-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland

      reply	other threads:[~2011-06-08 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  6:57 [PATCH] Support for more flexible effort specifications in TaskJuggler exporter Stuart Hickinbottom
2011-06-08 15:27 ` Christian Egli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lixcfimk.fsf@sbs.ch \
    --to=christian.egli@sbs.ch \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).