From: Bastien <bzg@altern.org>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org, Nicolas Goaziou <n.goaziou@gmail.com>,
Osamu OKANO <okano.osamu@gmail.com>
Subject: Re: TODO type problem on speedbar and imenu.
Date: Wed, 17 Aug 2011 18:07:01 +0200 [thread overview]
Message-ID: <87liusnhsq.fsf@gnu.org> (raw)
In-Reply-To: <82A68A74-84F0-4C21-B34E-CDEA4205F3E5@gmail.com> (Carsten Dominik's message of "Wed, 17 Aug 2011 09:30:28 +0200")
Hi Carsten and Nicolas,
Carsten Dominik <carsten.dominik@gmail.com> writes:
>> Notwithstanding the fontification problem, isn't "* TODO" considered as
>> a valid task, whose text is "TODO" and without a keyword?
>
> Well, the behavior is really undefined on these border cases.
There are side-effects to the current behavior.
Basically, in headlines like "* TODO", the TODO keyword will not be
matched correctly. So in column view, "TODO" will be displayed as the
ITEM instead of the TODO keyword, which will certainly be confusing for
users (see my other email).
I suggest enforcing [ \t\n] instead of [ \t] to make sure those
headlines are handled correctly.
> My worries also stem from the possibility that the match
> of these regexps now extends an additional character, and
> there may be places in the code which rely on (match-end 0)
> being right after (e.g.) the TODO keyword.
> I do not know if this is the case, but it
> is a definite possibility.
Whether this is the case or not, I think the correct fix is to
enforce [ \t\n] _outside_ the TODO keyword submatch.
Nicolas, can you make the two suggested changes, i.e. using
[ \t\n] and make sure this string is required outside the TODO
keyword submatch?
If you don't have time just let me know and I'll do it.
Thanks!
--
Bastien
next prev parent reply other threads:[~2011-08-17 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 12:51 TODO type problem on speedbar and imenu Osamu OKANO
2010-07-23 9:06 ` Noorul Islam K M
2010-07-24 21:38 ` Sébastien Vauban
2010-07-25 11:48 ` Osamu OKANO
2010-08-01 12:50 ` David Maus
2011-07-21 0:07 ` Nicolas Goaziou
2011-07-21 7:19 ` Sebastien Vauban
2011-07-24 19:00 ` Bastien
2011-08-13 10:16 ` Nicolas Goaziou
2011-08-16 14:47 ` Bastien
2011-08-16 20:54 ` Nicolas Goaziou
2011-08-17 16:00 ` Bastien
2011-08-17 18:16 ` Nicolas Goaziou
2011-08-24 14:18 ` Bastien
2011-08-24 14:37 ` Carsten Dominik
2011-08-25 0:31 ` Nicolas Goaziou
2011-08-16 21:07 ` Carsten Dominik
2011-08-16 21:44 ` Nicolas Goaziou
2011-08-17 7:30 ` Carsten Dominik
2011-08-17 16:07 ` Bastien [this message]
2011-08-17 15:57 ` Bastien
2011-08-17 17:45 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87liusnhsq.fsf@gnu.org \
--to=bzg@altern.org \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=n.goaziou@gmail.com \
--cc=okano.osamu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).