From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: PATCH[3/3]: org-element.el: Remove illegal t clause in case Date: Thu, 30 Aug 2012 10:28:29 +0200 Message-ID: <87ligwss0i.fsf@altern.org> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:41477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7072-0005xa-6F for emacs-orgmode@gnu.org; Thu, 30 Aug 2012 04:28:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T706w-0007Xe-Ed for emacs-orgmode@gnu.org; Thu, 30 Aug 2012 04:28:28 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:57336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T706w-0007Xa-8f for emacs-orgmode@gnu.org; Thu, 30 Aug 2012 04:28:22 -0400 Received: by wibhn17 with SMTP id hn17so1304357wib.12 for ; Thu, 30 Aug 2012 01:28:21 -0700 (PDT) In-Reply-To: (Michael Sperber's message of "Thu, 30 Aug 2012 09:56:30 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Sperber Cc: Mats Lidell , emacs-orgmode@gnu.org Hi Michael and Mats, Michael Sperber writes: > This patch (written by Mats Lidell) fixes an error we saw on XEmacs, but > we think it's a bug on GNU Emacs, too. Thank you both for the patch! I just applied it. I changed the commit log. At least in GNU Emacs, t is allowed, but only as the last clause. See the docstring of `case': [...] A KEYLIST of t or `otherwise' is allowed only in the final clause, and matches if no other keys match. Key values are compared by `eql'. I guess this is the same for XEmacs, would be strange otherwise. Best, -- Bastien