From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daimrod Subject: Re: phone links... Date: Sat, 20 Apr 2013 17:59:39 +0200 Message-ID: <87li8ddx5b.fsf@tanger.home> References: <5156228C.4010400@sift.info> <871uaq7aqy.fsf@bzg.ath.cx> <515E3938.2030202@sift.info> <20130408103832.GE659@strey.biz> <5162BC78.7010509@sift.info> <20130408140731.GF659@strey.biz> <5162D7BC.3020303@sift.info> <20130409073140.GJ659@strey.biz> <20130414204929.GY659@strey.biz> <87r4iam7zd.fsf@tanger.home> <20130417102847.GC659@strey.biz> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTaAV-00041A-9V for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 11:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTaAT-000557-O3 for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 11:57:39 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:54674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTaAT-00054x-EG for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 11:57:37 -0400 Received: by mail-wg0-f42.google.com with SMTP id m15so308473wgh.5 for ; Sat, 20 Apr 2013 08:57:36 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Michael Strey writes: >> - You should use `org-link-display-format' instead of >> `org-contacts-strip-link'. > > I don't think so. `org-link-display-format' returns the description of > the link if there is one. My `org-contacts-strip-link' always returns > the target. Using `org-link-display-format' would lead to wrong results > with links like > [[mailto:foo@bar.com][foo (at) bar (dot) com]] > [[tel:+49 351 4129535][+49 (0)351 4129535]] You're right, I had misunderstood the function. >> - You have done some unrelated changes (fix some typos, ...), could you >> provide a separated patches for them? > > Oh =3D:-|, another struggle with Git. I'm still learning and will do my = best. If you're not already using magit[1] I highly recommend it to you. You can use it to commit only a portion of the changes (you can also do it with "git commit --interactive" but I find it easier with magit). >> Regarding `org-contacts-split-property', I haven't found anything about >> multiple values within a node property in `org-element' and the syntax >> description doesn't mention it, so you were right to roll your own. :) > > That wasn't me. This (disputable) feature was already there for the > :EMAIL: proprerty. Actually, I don't like multiple values within a node > property and would prefer a VCard-like syntax like > > #+BEGIN_SRC org > *** Strey, Michael > :PROPERTIES: > :KIND: individual > :ORG: STREY Consult > :FN: Michael Strey > :N: Strey;Michael;; > :ADR;TYPE=3Dhome:;;my street;my city;federal state;post code;my country > :EMAIL: mailto:strey@myprovider.de > :EMAIL;PREF=3D1: mailto:me@mycompany.biz > :TEL;TYPE=3D"fax,work":[[tel:0321 21104568]] > :TEL;TYPE=3D"fax,home":[[tel:0351 4129535]] > :TEL;TYPE=3D"voice,home":[[tel:0351 4129535]] > :LANG: de > :ICON: ~/GTD/Icons/icon-strey_michael.jpg > :END: > #+END_SRC I must admit I am unsure about this. On one side it does solve some problems, on the other side I don't really like the idea of adding this extra syntax on top of properties. I think it's fine to use semicolons to separate values in node properties, but I would like to expose a clean API to manipulate users and user's properties so that we don't have to use `*-split-*' everywhere. For example it could expose your previous example into this: #+BEGIN_SRC lisp '((kind "individual") (org "STREY Consult") (fn "Michael Strey") (n ("Stry" "Michael" "")) (adr ("" "" "my street" "my city" "federal state" "post code" "my count= ry") :type home) (email "mailto:strey@myprovider.de") (email "mailto:me@mycompany.biz" :pref 1) (tel "[[tel:0321 21104568]]" :type "fax,work") (tel "[[tel:0351 4129535]]" :type "fax,home") (tel "[[tel:0351 4129535]]" :type "voice,home") (lang "de") (icon "~/GTD/Icons/icon-strey_michael.jpg"))=20=20 #+END_SRC >> However, I think it would be better to store the separators in a >> variable (like `org-contacts-property-values-separator') and maybe even >> to use it by default instead of `split-string-default-separators' >> because we use it more and because it's easy to forget. > > That was already hard-coded before in Feng's > `org-contacts-vcard-format'. But yes, you are right. Since it is > limited by some constraints we should make it an extra variable. > >>=20 >> > + (loop for email in (org-contacts-split-property email= -list) >> = ^^^^ >> > + for gravatar =3D (gravatar-retrieve-synchronous= ly (org-contacts-strip-link email)) > > This should be correctly and worked for me during my tests. > Confusingly `email-list' is not a list but a string here. My bad (again :/). Regards, 1. https://github.com/magit/magit =2D-=20 Daimrod/Greg --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRcrt0AAoJEBNzVHcrZRiUy6UP/R9zU2Wx8+U2R/6qbqeeWX5C /ScR9y28uzfqdXqYj6k6oi4zGzUYGoPDTfsFapxv4z1k7JO3o8UNswFB2b1GfZL0 l1Wax47gPyQyYkZrY+YiEch/COa9qtPdmDD0VBGJU+TGXD6tHK6v6fVeBfNLW0RQ myo+z7cuMFxrtfPV5g6FHvJ3SsrgRsbFaYivdDxDRqjix3lqBQEozGaN6aTPkFbb ZprdoCqcaouZcDPMXGDKAY3h5HFI1y1/rMmy2lzn4enpVS8pm/iQNd0SKC2y8oF0 PQ9IKxJiNDUEUwyJsrLLWOHbsRlxG6F+/F7/RWlS3npFF7rQKH3fakCaY2jMhB1L T7caoBPredE6dBS+2jGrRnRdLnYrOWIssq0A5R9WdRuKBs5ALiuW8osacdEn4ahq ZMToXvYX4+0GMOBOAS3Jr5IV4SEaMHMEIPDScOGnA9O3oSUhjLXP/R2NvNznOzU9 9W021rJapYw9gJov49Gs43yVPtYKnn9n1E0cNf/9Zh2CCy4yzsr4hKSQc0iwDHSm /6yV/6UcExOjKx6+J+y6YXG2bIWW6yHr+SQlxSBc2/XFfkkkDWrP+6lLNDb65Phz MNooHUMYgJUfiT55PInKKUpklERCB/VrEXRFbi0jTeKk52sii2qUXPfa3ahCmoYk xsq8rUKLSMMGoA3UOhhx =fvyX -----END PGP SIGNATURE----- --=-=-=--