From: Daimrod <daimrod@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: phone links...
Date: Sat, 20 Apr 2013 17:59:39 +0200 [thread overview]
Message-ID: <87li8ddx5b.fsf@tanger.home> (raw)
In-Reply-To: 20130417102847.GC659@strey.biz
[-- Attachment #1: Type: text/plain, Size: 3928 bytes --]
Michael Strey <mstrey@strey.biz> writes:
>> - You should use `org-link-display-format' instead of
>> `org-contacts-strip-link'.
>
> I don't think so. `org-link-display-format' returns the description of
> the link if there is one. My `org-contacts-strip-link' always returns
> the target. Using `org-link-display-format' would lead to wrong results
> with links like
> [[mailto:foo@bar.com][foo (at) bar (dot) com]]
> [[tel:+49 351 4129535][+49 (0)351 4129535]]
You're right, I had misunderstood the function.
>> - You have done some unrelated changes (fix some typos, ...), could you
>> provide a separated patches for them?
>
> Oh =:-|, another struggle with Git. I'm still learning and will do my best.
If you're not already using magit[1] I highly recommend it to you. You
can use it to commit only a portion of the changes (you can also do it
with "git commit --interactive" but I find it easier with magit).
>> Regarding `org-contacts-split-property', I haven't found anything about
>> multiple values within a node property in `org-element' and the syntax
>> description doesn't mention it, so you were right to roll your own. :)
>
> That wasn't me. This (disputable) feature was already there for the
> :EMAIL: proprerty. Actually, I don't like multiple values within a node
> property and would prefer a VCard-like syntax like
>
> #+BEGIN_SRC org
> *** Strey, Michael
> :PROPERTIES:
> :KIND: individual
> :ORG: STREY Consult
> :FN: Michael Strey
> :N: Strey;Michael;;
> :ADR;TYPE=home:;;my street;my city;federal state;post code;my country
> :EMAIL: mailto:strey@myprovider.de
> :EMAIL;PREF=1: mailto:me@mycompany.biz
> :TEL;TYPE="fax,work":[[tel:0321 21104568]]
> :TEL;TYPE="fax,home":[[tel:0351 4129535]]
> :TEL;TYPE="voice,home":[[tel:0351 4129535]]
> :LANG: de
> :ICON: ~/GTD/Icons/icon-strey_michael.jpg
> :END:
> #+END_SRC
I must admit I am unsure about this. On one side it does solve some
problems, on the other side I don't really like the idea of adding this
extra syntax on top of properties.
I think it's fine to use semicolons to separate values in node
properties, but I would like to expose a clean API to manipulate users
and user's properties so that we don't have to use `*-split-*'
everywhere.
For example it could expose your previous example into this:
#+BEGIN_SRC lisp
'((kind "individual")
(org "STREY Consult")
(fn "Michael Strey")
(n ("Stry" "Michael" ""))
(adr ("" "" "my street" "my city" "federal state" "post code" "my country") :type home)
(email "mailto:strey@myprovider.de")
(email "mailto:me@mycompany.biz" :pref 1)
(tel "[[tel:0321 21104568]]" :type "fax,work")
(tel "[[tel:0351 4129535]]" :type "fax,home")
(tel "[[tel:0351 4129535]]" :type "voice,home")
(lang "de")
(icon "~/GTD/Icons/icon-strey_michael.jpg"))
#+END_SRC
>> However, I think it would be better to store the separators in a
>> variable (like `org-contacts-property-values-separator') and maybe even
>> to use it by default instead of `split-string-default-separators'
>> because we use it more and because it's easy to forget.
>
> That was already hard-coded before in Feng's
> `org-contacts-vcard-format'. But yes, you are right. Since it is
> limited by some constraints we should make it an extra variable.
>
>>
>> > + (loop for email in (org-contacts-split-property email-list)
>> ^^^^
>> > + for gravatar = (gravatar-retrieve-synchronously (org-contacts-strip-link email))
>
> This should be correctly and worked for me during my tests.
> Confusingly `email-list' is not a list but a string here.
My bad (again :/).
Regards,
1. https://github.com/magit/magit
--
Daimrod/Greg
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2013-04-20 15:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 23:23 phone links Robert Goldman
2013-03-30 9:12 ` Karl Voit
2013-04-01 13:30 ` Robert Goldman
2013-04-03 14:52 ` Michael Strey
2013-04-03 15:05 ` Robert Goldman
2013-04-04 8:26 ` Michael Strey
2013-04-04 13:55 ` Michael Strey
2013-04-04 12:15 ` Bastien
2013-04-04 20:38 ` Simon Thum
2013-04-05 3:04 ` Robert P. Goldman
2013-04-05 6:42 ` Bastien
2013-04-06 12:05 ` Simon Thum
2013-04-06 12:10 ` Simon Thum
2013-04-06 20:58 ` Bastien
2013-04-05 2:38 ` Robert P. Goldman
2013-04-08 10:38 ` Michael Strey
2013-04-08 12:47 ` Robert Goldman
2013-04-08 14:07 ` Michael Strey
2013-04-08 14:44 ` Robert Goldman
2013-04-09 7:31 ` Michael Strey
2013-04-09 12:19 ` Robert Goldman
2013-04-09 14:40 ` Michael Strey
2013-04-13 14:12 ` Feng Shu
2013-04-13 14:43 ` Feng Shu
2013-04-14 8:38 ` Bastien
2013-04-14 14:31 ` Feng Shu
2013-04-15 15:39 ` Bastien
2013-04-15 23:37 ` Feng Shu
2013-04-16 21:11 ` Daimrod
2013-04-17 3:55 ` Feng Shu
2013-04-17 6:10 ` Daimrod
2013-04-14 20:49 ` Michael Strey
2013-04-16 22:22 ` Daimrod
2013-04-17 10:28 ` Michael Strey
2013-04-20 15:59 ` Daimrod [this message]
2013-04-26 12:48 ` [Patch] " Michael Strey
2013-04-30 9:09 ` Daimrod
2013-05-31 0:04 ` Daimrod
2013-04-09 9:57 ` Feng Shu
2013-04-10 14:17 ` Michael Strey
2013-04-11 10:27 ` Michael Strey
2013-04-16 7:57 ` Eric S Fraga
2013-04-16 12:25 ` Robert P. Goldman
2013-04-17 8:14 ` Michael Strey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li8ddx5b.fsf@tanger.home \
--to=daimrod@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).