From mboxrd@z Thu Jan 1 00:00:00 1970 From: Max Mikhanosha Subject: Re: RFQ - new contribution - org-screenshot.el Date: Fri, 17 May 2013 06:41:20 -0400 Message-ID: <87li7d99db.wl%max@openchat.com> References: <87mwru8f57.wl%max@openchat.com> <874ne23zir.fsf@bzg.ath.cx> <87ppwqawei.fsf@krugs.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([208.118.235.92]:54368) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdI6I-0003dY-Cg for emacs-orgmode@gnu.org; Fri, 17 May 2013 06:41:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdI6E-0007Df-Lr for emacs-orgmode@gnu.org; Fri, 17 May 2013 06:41:24 -0400 In-Reply-To: <87ppwqawei.fsf@krugs.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: "Rainer M. Krug" Cc: Bastien , emacs-orgmode@gnu.org At Fri, 17 May 2013 09:38:29 +0200, Rainer M. Krug wrote: > > Nice and very useful. Can this be included in /contrib? That is my intention, I have the FSF paper signed for Emacs and Org. So what I'm looking for some minimum amount of eyes on the code, and advice as to minimum set of things I need to adjust before committing it? My list is. 1. Convert defvar to defcustom 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in dired.el 3. The prefix C-c M-s seems awkward but Org is so big everything else is taken, and C-c C-x s is too close to C-c C-x C-s, which is archive subtree (I initially had it there and moved after archiving subtree by mistake) Its its fine to go in as is, then its fine too, I'm pretty lazy :-) Regards, Max