From: Nick Dokos <ndokos@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: commit 5ea0228 has problem opening big org-mode file
Date: Mon, 25 Nov 2013 23:53:38 -0500 [thread overview]
Message-ID: <87li0b4vcd.fsf@gmail.com> (raw)
In-Reply-To: 87pppn4wg2.fsf@gmail.com
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
Nick Dokos <ndokos@gmail.com> writes:
> The best solution I can think of so far: revert commit 5ea0228,
> and change org-mode-restart to call normal-mode, instead of org-mode.
> normal-mode splits the setting of the mode from the setting of local
> variables, so it would avoid the recursion.
>
> I think (but I have not verified yet) that this would fix both the
> problem that gave rise to commit 5ea0228 in the first place and this
> bottomless recursion, without causing any other problems. I'll try it
> out tomorrow if I find the time and submit a patch.
Patch attached. It passed the two tests, but I have not done anything
more. Can both interested parties (York Zhao and Tom Dye) please test it
and let me know of any problems?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to set file local variables (second try) --]
[-- Type: text/x-diff, Size: 1044 bytes --]
diff --git a/lisp/org.el b/lisp/org.el
index 7a4d244..677d298 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -5512,10 +5512,7 @@ The following commands are available:
(unless org-inhibit-startup-visibility-stuff
(org-set-startup-visibility))))
;; Try to set org-hide correctly
- (set-face-foreground 'org-hide (org-find-invisible-foreground))
- ;; Make sure that file local variables are set.
- (report-errors "File local-variables error: %s"
- (hack-local-variables)))
+ (set-face-foreground 'org-hide (org-find-invisible-foreground)))
;; Update `customize-package-emacs-version-alist'
(add-to-list 'customize-package-emacs-version-alist
@@ -20469,7 +20466,8 @@ This command does many different things, depending on context:
"Restart Org-mode, to scan again for special lines.
Also updates the keyword regular expressions."
(interactive)
- (org-mode)
+ ;; this will set the mode *and* set file local variables.
+ (normal-mode)
(message "Org-mode restarted"))
(defun org-kill-note-or-show-branches ()
[-- Attachment #3: Type: text/plain, Size: 18 bytes --]
Thanks,
--
Nick
next prev parent reply other threads:[~2013-11-26 4:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 3:55 commit 5ea0228 has problem opening big org-mode file York Zhao
2013-11-25 4:28 ` Nick Dokos
2013-11-25 16:57 ` Nick Dokos
2013-11-25 19:26 ` Thomas S. Dye
2013-11-25 22:39 ` York Zhao
2013-11-26 1:38 ` York Zhao
2013-11-26 4:29 ` Nick Dokos
2013-11-26 4:53 ` Nick Dokos [this message]
2013-11-27 2:26 ` York Zhao
2013-11-27 2:29 ` Thomas S. Dye
2013-11-27 14:27 ` Nick Dokos
2013-11-27 18:58 ` Achim Gratz
2013-11-27 19:23 ` Nick Dokos
2013-11-27 19:53 ` Achim Gratz
2013-11-26 19:25 ` Achim Gratz
2013-11-27 1:46 ` York Zhao
2013-11-27 7:24 ` Achim Gratz
2013-11-28 0:17 ` York Zhao
2013-11-28 7:25 ` Achim Gratz
2013-11-29 3:58 ` York Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li0b4vcd.fsf@gmail.com \
--to=ndokos@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).