From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: pdf page numbers in links are ignored when exporting to
 latex [8.2.7b (8.2.7b-13-gd8a0ee-elpa @
 /home/moritz/.emacs.d/elpa/org-20140728/)]
Date: Fri, 01 Aug 2014 11:22:17 +0200
Message-ID: <87lhr8womu.fsf@nicolasgoaziou.fr>
References: <87silj7vqg.fsf@gmail.com> <87silir3lp.fsf@nicolasgoaziou.fr>
	<87tx5xz2kr.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48315)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XD922-0006G6-9U
	for emacs-orgmode@gnu.org; Fri, 01 Aug 2014 05:21:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XD91r-0005to-3i
	for emacs-orgmode@gnu.org; Fri, 01 Aug 2014 05:21:46 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:48908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XD91q-0005tb-UQ
	for emacs-orgmode@gnu.org; Fri, 01 Aug 2014 05:21:35 -0400
In-Reply-To: <87tx5xz2kr.fsf@gmail.com> (Moritz Kiefer's message of "Thu, 31
	Jul 2014 22:29:01 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Moritz Kiefer <moritz.kiefer@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Moritz Kiefer <moritz.kiefer@gmail.com> writes:

> This is my first attempt at elisp so it's probably terrible code

It's not. Thanks for the patch. Some comments follow.

> * lisp/ox-latex.el (org-latex--inline-image): Use page
> number (:search-option) of pdf links as page option in includegraphics

Missing full stop.

You also need to add "TINYCHANGE" on a line below if you don't have
signed FSF papers yet.

> ---
>  lisp/ox-latex.el | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index ceea302..edbde70 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -1861,6 +1861,10 @@ used as a communication channel."
>  	(setq options (concat options ",width=" width)))
>        (when (org-string-nw-p height)
>  	(setq options (concat options ",height=" height)))
> +      (when (and (equal filetype "pdf")
> +                 (string-match "\\`[0-9]+\\'" (org-element-property :search-option link))
> +                 (not (string-match "page=" options)))
> +	(setq options (concat options ",page=" (org-element-property :search-option link))))

I suggest to let-bind SEARCH-OPTION instead of calling
`org-element-property' twice. Also, it's better to use
`org-string-match-p' instead of `string-match' since you don't use
match-data anyway. Eventually, you need to check if SEARCH-OPTION is
non-nil, as (string-match REGEXP nil) throws an error.

  (let ((search-option (org-element-property :search-option link)))
    (when (and search-option
               (equal filetype "pdf")
               (org-string-match-p "\\`[0-9]+\\'" search-option)
               ...)
      ...))


Regards,

-- 
Nicolas Goaziou                                                0x80A93738