emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Moritz Kiefer <moritz.kiefer@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: pdf page numbers in links are ignored when exporting to latex [8.2.7b (8.2.7b-13-gd8a0ee-elpa @ /home/moritz/.emacs.d/elpa/org-20140728/)]
Date: Fri, 01 Aug 2014 11:22:17 +0200	[thread overview]
Message-ID: <87lhr8womu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87tx5xz2kr.fsf@gmail.com> (Moritz Kiefer's message of "Thu, 31 Jul 2014 22:29:01 +0200")

Hello,

Moritz Kiefer <moritz.kiefer@gmail.com> writes:

> This is my first attempt at elisp so it's probably terrible code

It's not. Thanks for the patch. Some comments follow.

> * lisp/ox-latex.el (org-latex--inline-image): Use page
> number (:search-option) of pdf links as page option in includegraphics

Missing full stop.

You also need to add "TINYCHANGE" on a line below if you don't have
signed FSF papers yet.

> ---
>  lisp/ox-latex.el | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lisp/ox-latex.el b/lisp/ox-latex.el
> index ceea302..edbde70 100644
> --- a/lisp/ox-latex.el
> +++ b/lisp/ox-latex.el
> @@ -1861,6 +1861,10 @@ used as a communication channel."
>  	(setq options (concat options ",width=" width)))
>        (when (org-string-nw-p height)
>  	(setq options (concat options ",height=" height)))
> +      (when (and (equal filetype "pdf")
> +                 (string-match "\\`[0-9]+\\'" (org-element-property :search-option link))
> +                 (not (string-match "page=" options)))
> +	(setq options (concat options ",page=" (org-element-property :search-option link))))

I suggest to let-bind SEARCH-OPTION instead of calling
`org-element-property' twice. Also, it's better to use
`org-string-match-p' instead of `string-match' since you don't use
match-data anyway. Eventually, you need to check if SEARCH-OPTION is
non-nil, as (string-match REGEXP nil) throws an error.

  (let ((search-option (org-element-property :search-option link)))
    (when (and search-option
               (equal filetype "pdf")
               (org-string-match-p "\\`[0-9]+\\'" search-option)
               ...)
      ...))


Regards,

-- 
Nicolas Goaziou                                                0x80A93738

  parent reply	other threads:[~2014-08-01  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 20:31 Moritz Kiefer
2014-07-30 20:30 ` Nicolas Goaziou
     [not found]   ` <87tx5xz2kr.fsf@gmail.com>
2014-08-01  9:22     ` Nicolas Goaziou [this message]
2014-08-01 19:21       ` Moritz Kiefer
2014-08-02  8:25         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhr8womu.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=moritz.kiefer@gmail.com \
    --subject='Re: Bug: pdf page numbers in links are ignored when exporting to latex [8.2.7b (8.2.7b-13-gd8a0ee-elpa @ /home/moritz/.emacs.d/elpa/org-20140728/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).