emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: [bug] TODO [/] cookie not updating if list has inline task
Date: Sun, 17 May 2015 21:02:24 +0200	[thread overview]
Message-ID: <87lhgnxc1r.fsf@gmx.us> (raw)
In-Reply-To: <877fs782c3.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sun, 17 May 2015 20:51:24 +0200")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Rasmus <rasmus@gmx.us> writes:
>
>> Can you try the attached patch?  It seems to work on my system, but
>> probably more cleanup should be made wrt the "old" outline-functions.
>> +			  (org-with-wide-buffer
>> +			   (org-next-visible-heading 1)
>> +			   (point)))))
>
> You shouldn't use `org-next-visible-heading' as statistics cookie
> updates shouldn't depend on current visibility.

That's why I used org-with-wide-buffer.  But perhaps a better solution
would be an org-next-heading or whatever, that considered inlinetasks.

> Also, the problem is more subtle: you have to check if you're within an
> inlinetask, in which case you don't want to use
> `org-with-limited-levels' or not.

Is that saying that org-with-wide-buffer is no good here?

> Anyway, we could fix it in another way. Eric's example,
>
>   - [ ] the first task
>     
>   *************** This is something to note
>   *************** END
>
>   - [ ] another list of tasks
>
> is misleading because it's really the same list, i.e., inlinetasks are
> allowed in items, so "This is something to note" belongs to "the first
> task".
>
> So, our option is to simply dis-allow inlinetasks in plain lists. That
> would also solve the issue.

It solves the problem, unless Eric wants inlinetasks in his list.  The
"solution" in my other patch recognized both checkboxes.

> WDYT?

I haven't needed inlinetasks in lists.  So I don't care much.  Better wait
for Eric's opinion.

—Rasmus

-- 
I feel emotional landscapes they puzzle me

  reply	other threads:[~2015-05-17 19:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-17 11:22 [bug] TODO [/] cookie not updating if list has inline task Eric S Fraga
2015-05-17 13:08 ` Eric S Fraga
2015-05-17 13:23   ` Eric S Fraga
2015-05-17 13:32     ` Rasmus
2015-05-17 13:51 ` Rasmus
2015-05-17 18:26   ` Eric S Fraga
2015-05-17 18:27   ` Eric S Fraga
2015-05-17 18:51   ` Nicolas Goaziou
2015-05-17 19:02     ` Rasmus [this message]
2015-05-17 21:56       ` Nicolas Goaziou
2015-05-20  8:26         ` e.fraga
2015-06-09 15:09           ` Nicolas Goaziou
2015-06-11 14:40             ` e.fraga
2015-05-17 19:28     ` Eric S Fraga
2015-05-17 19:44       ` Rasmus
2015-05-17 22:05         ` Nicolas Goaziou
2015-05-18  8:16         ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lhgnxc1r.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).