From: Nicolas Richard <youngfrog@members.fsf.org>
To: Nicolas Richard <youngfrog@members.fsf.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-columns adds spaces [8.3beta (release_8.3beta-1286-g20795f @ /home/youngfrog/sources/org-mode/lisp/)]
Date: Mon, 13 Jul 2015 14:52:52 +0200 [thread overview]
Message-ID: <87lhekb4nv.fsf@members.fsf.org> (raw)
In-Reply-To: <86615ocmug.fsf@members.fsf.org> (Nicolas Richard's message of "Mon, 13 Jul 2015 13:34:47 +0200")
Nicolas Richard <youngfrog@members.fsf.org> writes:
> The buffer is still marked "unmodified" but there are five space
> characters at the end of the headline. (and this will later confuse org
> element cache which thus give errors, but I guess that's to be
> expected.)
Meanwhile I had a look and it's due to this part of
org-columns-display-here :
(org-unmodified (insert " "))
(http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-colview.el?h=maint#n247)
Inserting characters in the buffer for the sake of columnview seems
wrong to me. Even more so if this is done silently.
I tried removing the whole (if then) block. That not only helps with the
spurious spaces, but also makes the column view work better in my
original usecase. OTOH I don't know what it will break.
--- /home/youngfrog/sources/org-mode/lisp/org-colview.el
+++ #<buffer org-colview.el>
@@ -224,13 +224,7 @@
(overlay-put ov 'org-columns-pom pom)
(overlay-put ov 'org-columns-format f)
(overlay-put ov 'line-prefix "")
- (overlay-put ov 'wrap-prefix ""))
- (if (or (not (char-after beg))
- (equal (char-after beg) ?\n))
- (let ((inhibit-read-only t))
- (save-excursion
- (goto-char beg)
- (org-unmodified (insert " ")))))) ;; FIXME: add props and remove later?
+ (overlay-put ov 'wrap-prefix "")))
;; Make the rest of the line disappear.
(org-unmodified
(setq ov (org-columns-new-overlay beg (point-at-eol)))
--
Nicolas Richard
next prev parent reply other threads:[~2015-07-13 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 11:34 Bug: org-columns adds spaces [8.3beta (release_8.3beta-1286-g20795f @ /home/youngfrog/sources/org-mode/lisp/)] Nicolas Richard
2015-07-13 12:52 ` Nicolas Richard [this message]
2015-07-18 7:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhekb4nv.fsf@members.fsf.org \
--to=youngfrog@members.fsf.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).