From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] ob-vala.el: Add Vala support to Babel
Date: Sun, 06 Aug 2017 02:22:31 +0200
Message-ID: <87lgmxfsu0.fsf@nicolasgoaziou.fr>
References: <87fudze7y4.fsf@nicolasgoaziou.fr>
	<1500061387-3353-1-git-send-email-mitch@cgarbs.de>
	<87379no75t.fsf@nicolasgoaziou.fr>
	<20170801212052.lc64vzvuluglctqq@cgarbs.de>
	<87ini7q721.fsf@nicolasgoaziou.fr>
	<20170802202404.lltnk4rs5mt7opgw@cgarbs.de>
	<87vam5kjsn.fsf@nicolasgoaziou.fr>
	<20170805195312.srqvrch3ia3bnjqf@cgarbs.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1de9L3-0006vx-Ab
	for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 20:22:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1de9L2-0005m9-1E
	for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 20:22:37 -0400
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:37193)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1de9L1-0005ki-Qt
	for emacs-orgmode@gnu.org; Sat, 05 Aug 2017 20:22:35 -0400
In-Reply-To: <20170805195312.srqvrch3ia3bnjqf@cgarbs.de> (Christian Garbs's
	message of "Sat, 5 Aug 2017 21:53:14 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Christian Garbs <mitch@cgarbs.de>
Cc: emacs-orgmode@gnu.org

Hello,

Christian Garbs <mitch@cgarbs.de> writes:

> Byte-compiling works and gave me 5 warnings about unused variables and
> arguments which I could fix in different ways.

Note that the usual solution to get rid of unused arguments is to prefix
their name with "_".

> Currently I run into a problem with the test case:  I have created an
> org file containing some Vala code and an .el file with some tests,

It would be better to have all tests and data self contained in the same
".el" file, IMO.

> but the dependency check at the top of the test always fails:
>
> | (unless (featurep 'ob-vala)
> |   (signal 'missing-test-dependency "Support for Vala code blocks"))
>
> Removing the test results in errors.
>
> When I replace those two lines with
>
> | (require 'ob-vala)
>
> the tests run as expected, eg. they fail when I deliberately provoke
> an error and succeed otherwise.
>
> I think this is a dependency or build problem, but I don't know what
> exactly goes wrong or how to fix it.  I have searched the whole source
> for 'ob-C and 'ob-fortran to see how those tests and modules differ
> from 'ob-vala, but this yielded no result.
>
> My guess: It is something totally basic and trivial.
> Any ideas?

I don't see any problem. The tests are meant to run if user has loaded
"ob-vala", but the test suite shouldn't load that library on user's
behalf.

Regards,

-- 
Nicolas Goaziou