From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH]: Fix ob-haskell.el to work with custom ghci prompts Date: Wed, 29 Nov 2017 21:21:34 +0100 Message-ID: <87lgioomy9.fsf@nicolasgoaziou.fr> References: <87k1yque93.fsf@nicolasgoaziou.fr> <87y3n4tuvy.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eK8rV-0004s6-Ft for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 15:21:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eK8rR-0004DR-IG for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 15:21:41 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38657) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eK8rR-0004Bp-Bn for emacs-orgmode@gnu.org; Wed, 29 Nov 2017 15:21:37 -0500 In-Reply-To: (Doro Rose's message of "Sat, 18 Nov 2017 12:12:24 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Doro Rose Cc: emacs-orgmode@gnu.org Hello, Doro Rose writes: > Nicolas Goaziou writes: > >> Hello, >> >> Doro Rose writes: >> >>> In summary, yes I'm accessing user settings but in a rather >>> noninvasive way. Unfortunately I can't think of a more elegant way to >>> do this. >> >> Let's put it differently then. Isn't it the job of the user, who changed >> their prompt, to configure properly "inf-haskell" library? I don't get >> why it should be a task for "ob-haskell". >> >> This is a genuine question: I don't use Haskell at all. >> >> Regards, > > Well the "inf-haskell" library is fine as it is, i.e. the code sent to its buffer > is evaluated correctly in the corresponding buffer. > The problem occurs when sending code to that buffer via org-babel, since > the interpreter output isn't parsed correctly in `org-babel-comint-with-output`. > > As an org-babel user my expectation would be for that to just work out of the > box. -> Without having to figure out that I need to set internal variables defined in > "inf-haskell" or that I need to add `ansi-color-filter-apply` to > `comint-preoutput-filter-functions`. Fair enough. Could you provide a proper commit message and send the patch again? Thank you. Regards, -- Nicolas Goaziou