* [PATCH] contrib: ob-sclang: Fix compilation issue.
@ 2018-03-24 23:27 Maxim Cournoyer
2018-03-25 2:38 ` stardiviner
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Maxim Cournoyer @ 2018-03-24 23:27 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 95 bytes --]
Hello!
The attached patch fixes a byte compilation issue in ob-sclang.el.
Thank you!
Maxim
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-contrib-ob-sclang-Fix-compilation-issue.patch --]
[-- Type: text/x-patch, Size: 1113 bytes --]
From 0cbc7a1526cd5a87de776de86948bded399063c9 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Sat, 24 Mar 2018 19:13:42 -0400
Subject: [PATCH] contrib: ob-sclang: Fix compilation issue.
* contrib/lisp/ob-sclang.el: Require sclang instead of sclang-interp.
---
contrib/lisp/ob-sclang.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/ob-sclang.el b/contrib/lisp/ob-sclang.el
index ac47b9834..dcd4b6f74 100644
--- a/contrib/lisp/ob-sclang.el
+++ b/contrib/lisp/ob-sclang.el
@@ -24,7 +24,7 @@
;;; Commentary:
-;; `ob-sclang' requires `sclang-interp' from SuperCollider.
+;; `ob-sclang' requires `sclang' from SuperCollider.
;; Usually SuperCollider dependencies for Emacs are at /usr/share/emacs/site-lisp/SuperCollider/
;; You can install SuperCollider following this article:
;; https://github.com/supercollider/supercollider#building-the-source-code
@@ -60,7 +60,7 @@
(require 'org)
(require 'ob)
-(require 'sclang-interp)
+(require 'sclang)
(defgroup ob-sclang nil
"org-mode blocks for SuperCollider SCLang."
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] contrib: ob-sclang: Fix compilation issue.
2018-03-24 23:27 [PATCH] contrib: ob-sclang: Fix compilation issue Maxim Cournoyer
@ 2018-03-25 2:38 ` stardiviner
2018-03-25 21:29 ` Nicolas Goaziou
2018-03-26 11:38 ` stardiviner
2 siblings, 0 replies; 5+ messages in thread
From: stardiviner @ 2018-03-25 2:38 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hi, @MaximI'm the author of `ob-sclang.el`.
Whyneed to require `sclang` instead of `sclang-interp`? ob-sclangused
functions are all in `sclang-interp.el` file. No need to require
`sclang`. And I checked out `scel` source code, have not found update.
Might because `sclang-interp`?
On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:
> Hello!
>
> The attached patch fixes a byte compilation issue in ob-sclang.el.
>
> Thank you!
>
> Maxim
>
[-- Attachment #2: Type: text/html, Size: 2061 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] contrib: ob-sclang: Fix compilation issue.
2018-03-24 23:27 [PATCH] contrib: ob-sclang: Fix compilation issue Maxim Cournoyer
2018-03-25 2:38 ` stardiviner
@ 2018-03-25 21:29 ` Nicolas Goaziou
2018-03-26 11:38 ` stardiviner
2 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2018-03-25 21:29 UTC (permalink / raw)
To: Maxim Cournoyer; +Cc: emacs-orgmode
Hello,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> The attached patch fixes a byte compilation issue in ob-sclang.el.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] contrib: ob-sclang: Fix compilation issue.
2018-03-24 23:27 [PATCH] contrib: ob-sclang: Fix compilation issue Maxim Cournoyer
2018-03-25 2:38 ` stardiviner
2018-03-25 21:29 ` Nicolas Goaziou
@ 2018-03-26 11:38 ` stardiviner
2018-03-26 12:22 ` stardiviner
2 siblings, 1 reply; 5+ messages in thread
From: stardiviner @ 2018-03-26 11:38 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed.
Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in`
for built-time defaults. When user load sclang from source code of
`scel`. This will cause error.
Really don't understand why you have to `(require 'sclang)` instead of
`(require 'sclang-interp)`? Can you tell me why?
On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:
> Hello!
>
> The attached patch fixes a byte compilation issue in ob-sclang.el.
>
> Thank you!
>
> Maxim
>
[-- Attachment #2: Type: text/html, Size: 1715 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] contrib: ob-sclang: Fix compilation issue.
2018-03-26 11:38 ` stardiviner
@ 2018-03-26 12:22 ` stardiviner
0 siblings, 0 replies; 5+ messages in thread
From: stardiviner @ 2018-03-26 12:22 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
After dive into scel source code, I use cmake build fix. This seems an
old problem. Now fixed.
On 03/26/2018 07:38 PM, stardiviner wrote:
>
> You `(require 'sclang)` cause error on `(require 'sclang-vars)`
> failed. Because there is no file `sclang-vars.el`. Only file
> `sclang-vars.el.in` for built-time defaults. When user load sclang
> from source code of `scel`. This will cause error.
>
> Really don't understand why you have to `(require 'sclang)` instead of
> `(require 'sclang-interp)`? Can you tell me why?
>
>
> On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:
>> Hello!
>>
>> The attached patch fixes a byte compilation issue in ob-sclang.el.
>>
>> Thank you!
>>
>> Maxim
>>
>
[-- Attachment #2: Type: text/html, Size: 2329 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-26 12:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-24 23:27 [PATCH] contrib: ob-sclang: Fix compilation issue Maxim Cournoyer
2018-03-25 2:38 ` stardiviner
2018-03-25 21:29 ` Nicolas Goaziou
2018-03-26 11:38 ` stardiviner
2018-03-26 12:22 ` stardiviner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).