emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Renato Ferreira <renatofdds@gmail.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-protocol.el: Fix `org-protocol-capture' return value
Date: Tue, 18 Dec 2018 20:17:44 -0200	[thread overview]
Message-ID: <87lg4mh43b.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hello,

This fixes `org-protocol-capture' removing the message because protocols
with :kill-client exit it with `server-edit' causing
`server-visit-files' to receive "Item captured." which it interpret as a
file name.

-- 
Renato Ferreira

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-protocol.el-Fix-org-protocol-capture-return-valu.patch --]
[-- Type: text/x-patch, Size: 897 bytes --]

From 50a575a9816d65ae02443a149070763bf33b5213 Mon Sep 17 00:00:00 2001
From: Renato Ferreira <renatofdds@gmail.com>
Date: Tue, 18 Dec 2018 20:00:11 -0200
Subject: [PATCH] org-protocol.el: Fix `org-protocol-capture' return value

* lisp/org-protocol.el: Make sure protocols with :kill-client do
not return a string.

TINYCHANGE
---
 lisp/org-protocol.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index 88f471e7d..48d72db1c 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -503,8 +503,7 @@ Now template ?b will be used."
 			  :initial region
 			  :query parts)
     (raise-frame)
-    (org-capture nil template))
-  (message "Item captured."))
+    (org-capture nil template)))
 
 (defun org-protocol-convert-query-to-plist (query)
   "Convert QUERY key=value pairs in the URL to a property list."
-- 
2.20.1

next             reply	other threads:[~2018-12-18 22:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 22:17 Renato Ferreira [this message]
2018-12-19 21:17 ` [PATCH] org-protocol.el: Fix `org-protocol-capture' return value Nicolas Goaziou
2018-12-19 21:51   ` Renato Ferreira

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:88f471e7 dfblob:48d72db1
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg4mh43b.fsf@gmail.com \
    --to=renatofdds@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).