emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Sebastian Miele <sebastian.miele@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Respect buffer-local value of `org-edit-src-content-indentation'
Date: Wed, 12 Feb 2020 18:35:58 +0000	[thread overview]
Message-ID: <87lfp7lkkx.fsf@gmail.com> (raw)
In-Reply-To: <87a75nbsol.fsf@gnu.org>

Hi Bastien,

Bastien <bzg@gnu.org> writes:
>
> Sebastian Miele <sebastian.miele@gmail.com> writes:
>
> > * lisp/org-src.el (org-src--contents-for-write-back): Use the
> > potentially buffer-local value of `org-edit-src-content-indentation'
> > from the source buffer instead of that from the editing buffer.
>
> I'm not sure about I see why this patch would be useful.
>
> IIUC, in case `org-edit-src-content-indentation' is set in the src
> block buffer itself, you want Org to honor its value _there_ instead
> of the value this variable has in the org buffer (containing the src
> block)?

I am quite certain, that the content indentation conceptually and
technically belongs to the buffer containing the src block. Except for
src blocks containing org I see no point at all for setting a content
indentation in an edit buffer for the block. There just is no meaning of
an org src content indentation in e.g. an Elisp buffer.

And for an src buffer containing org the meaning would be the content
intentation for the org in the block, and not for the org containing the
block.

> I find it difficult to see a compelling use case, please let me know
> if I don't understand correctly.

Nicolas already accepted the patch. Currently it is included as commit
3649d95b in the history of master. Before accepting the patch, he too
asked for a use case. Please see

https://lists.gnu.org/archive/html/emacs-orgmode/2019-11/msg00052.html

for the answer.

Best wishes
Sebastian

next prev parent reply	other threads:[~2020-02-12 18:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 23:30 [PATCH] Respect buffer-local value of `org-edit-src-content-indentation' Sebastian Miele
2019-10-16  0:50 ` Adam Porter
2019-10-17  0:34   ` Sebastian Miele
2019-11-03 21:24     ` Nicolas Goaziou
2019-11-03 22:25       ` Sebastian Miele
2019-11-19 10:39         ` Nicolas Goaziou
2019-11-20  6:12           ` Sebastian Miele
2019-11-20 21:30             ` Nicolas Goaziou
2020-02-12 17:51 ` Bastien
2020-02-12 18:35   ` Sebastian Miele [this message]
2020-02-12 19:10     ` Bastien
2020-02-12 19:28       ` Sebastian Miele
2020-02-13 19:31         ` Sebastian Miele
2020-02-14 10:02           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfp7lkkx.fsf@gmail.com \
    --to=sebastian.miele@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).