From: Nicolas Goaziou <email@example.com> To: "Kévin Le Gouguec" <firstname.lastname@example.org> Cc: email@example.com Subject: Re: Setting org-todo-keywords through directory-local variables Date: Fri, 22 May 2020 17:11:22 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Fri, 22 May 2020 01:12:00 +0200") Hello, Kévin Le Gouguec <firstname.lastname@example.org> writes: > Kévin Le Gouguec <email@example.com> writes: > >> Can anyone confirm that this would (in principle) be the way forward, or >> tell me if I am missing something? > > I went ahead and cooked up a proof-of-concept patch, which > > (1) adds safe-local-variable properties to org-todo-keywords and > org-todo-keyword-faces, > > (2) stops applying default-value to org-todo-keywords, > > (3) delays regexps/font-lock setups until after file- and dir-local > variables have been set. > > While this patch contains a few things that make me weary, it solves > my use-case, and passes the current test suite with Emacs 26.3 and 28. > > Does this look sound overall? Does anyone have any idea what kind of > breakage might be slipping through the test suite? This looks hackish. Also, Org needs the STARTUP part early on, so you cannot really delay it. I /think/ the rest can be delayed, but I admit I'm not too sure either. I think the expected way to do this is to add a SETUPFILE. Regards, -- Nicolas Goaziou
next prev parent reply other threads:[~2020-05-22 15:11 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-20 21:12 Kévin Le Gouguec 2020-05-21 23:12 ` Kévin Le Gouguec 2020-05-22 15:11 ` Nicolas Goaziou [this message] 2020-05-23 12:58 ` Kévin Le Gouguec 2020-06-24 17:54 ` Kévin Le Gouguec 2020-09-05 15:39 ` Bastien 2020-05-22 8:42 ` Nicolas Goaziou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: Setting org-todo-keywords through directory-local variables' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).