From: TEC <tecosaur@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Bastien <bzg@gnu.org>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: (Feature Request) have org-edit-special work inside non-environment LaTeX blocks, i.e. \( \) and \[ \]
Date: Tue, 26 May 2020 17:23:21 +0800 [thread overview]
Message-ID: <87lflf82qp.fsf@gmail.com> (raw)
In-Reply-To: <87mu5v6oy2.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Without hesitation, the first form is nicer. The second one is
> just abusing let-binding. I die a little just by looking at it.
I'll make an attempt to avoid killing you then :P
> See `rx' macro. S-exp regexps are usually easier to read (after
> an initial struggle), and less likely to introduce subtle bugs.
> For long regexps, this is important. For this one, either way is
> fine.
I'll just remove the -p and be done with it then.
> Well. Ideally, let-binding should enclose the minimum part of
> the code that needs the binding. Sometimes, an exception is
> tolerated, because the code would contain too many nested
> let-forms. But, conversely, you shouldn't stuff every local
> variable at the beginning of the function and be done with it.
>
> In this particular case, there's no reason to stuff the `length'
> call at the top of the function when you need it later on, on a
> well-defined S-exp. IOW, it is more idiomatic to just add a
> let-binding around the appropriate (add-text-properties ...).
Somehow it feels like overkill to have
(let (contents-length (length contents))
...)
when it's only used twice :P
> But it should be ", so remove newlines."
Gah!
>> I recall being asked to list modified/added functions, what
>> else do I need?
>
> Nothing else.
Should be good then, as far as I can tell.
>>> Bonus points if you can add some tests in
>>> "testing/lisp/test-org-src.el".
>>
>> I'll have a look at that, but I'm not quite sure what to do.
>
> You could look at `test-org-src/footnote-references' for
> inspiration. However, I assume tests will be less complicated
> for LaTeX fragments.
I'll have a look.
> We're almost there, then.
Nice! :) I'll try to send through the next iteration soon.
next prev parent reply other threads:[~2020-05-26 9:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 1:31 (Feature Request) have org-edit-special work inside non-environment LaTeX blocks, i.e. \( \) and \[ \] Timothy
2020-05-19 7:47 ` Nicolas Goaziou
2020-05-19 9:27 ` Timothy
2020-05-19 9:39 ` Nicolas Goaziou
2020-05-19 9:45 ` Timothy
2020-05-19 13:27 ` Nicolas Goaziou
2020-05-19 13:32 ` Timothy
2020-05-19 14:09 ` Nicolas Goaziou
2020-05-19 14:12 ` Timothy
2020-05-19 14:28 ` Nicolas Goaziou
2020-05-19 14:33 ` Timothy
2020-05-23 9:10 ` Bastien
2020-05-23 9:20 ` tecosaur
2020-05-23 9:34 ` Bastien
2020-05-24 15:07 ` TEC
2020-05-24 15:38 ` TEC
2020-05-24 15:43 ` Timothy
2020-05-24 19:33 ` Nicolas Goaziou
2020-05-25 1:33 ` TEC
2020-05-25 7:11 ` Nicolas Goaziou
2020-05-25 9:28 ` TEC
2020-05-25 9:41 ` Nicolas Goaziou
2020-05-25 9:42 ` TEC
2020-05-25 9:55 ` TEC
2020-05-25 10:09 ` Nicolas Goaziou
2020-05-25 10:09 ` TEC
2020-05-25 10:23 ` Nicolas Goaziou
2020-05-25 10:24 ` TEC
2020-05-25 10:32 ` Nicolas Goaziou
2020-05-25 10:33 ` TEC
2020-05-25 10:05 ` TEC
2020-05-25 10:20 ` Nicolas Goaziou
2020-05-25 10:21 ` TEC
2020-05-25 11:27 ` Nicolas Goaziou
2020-05-25 13:22 ` Timothy
2020-05-25 14:08 ` TEC
2020-05-26 7:56 ` Nicolas Goaziou
2020-05-26 8:39 ` Timothy
2020-05-26 9:11 ` Nicolas Goaziou
2020-05-26 9:23 ` TEC [this message]
2020-05-26 13:56 ` TEC
2020-05-26 21:13 ` Nicolas Goaziou
2020-05-26 17:01 ` John Kitchin
2020-05-25 18:58 ` Nicolas Goaziou
2020-05-26 4:48 ` TEC
2020-05-25 10:11 ` Nicolas Goaziou
2020-05-25 10:17 ` TEC
-- strict thread matches above, loose matches on Subject: below --
2020-05-18 6:44 Timothy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lflf82qp.fsf@gmail.com \
--to=tecosaur@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).