From: Jack Kamm <email@example.com>
To: Bastien <firstname.lastname@example.org>
"Adrian Kummerländer" <email@example.com>
Subject: Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Date: Sat, 24 Oct 2020 07:06:26 -0700 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
Thanks Bastien, the Woof! tool looks interesting.
By the way, on seeing this thread again, I realized this patch probably should have been applied to the maint branch. So I've cherry picked it into there, and merged back into master.
Bastien <email@example.com> writes:
> Hi Jack and Adrian,
> Jack Kamm <firstname.lastname@example.org> writes:
>> Adrian Kummerländer <email@example.com> writes:
>>> I noticed that after updating to Org 9.4 many of my Python-based Org
>>> files fail to execute with various `io.TextIOWrapper' related error
>>> messages. The reason for this is that opening the exec tmpfile as `f'
>>> shadows this possibly user-defined variable.
>>> The attached patch fixes this problem for me. As this is my first
>>> time contributing to Org I am especially open for any suggestions!
>> The patch looks good. I've pushed it to master, after making a couple
>> minor fixes to the commit message (adding a TINYCHANGE cookie and
>> adjusting some of the spacing).
> Thanks for applying the patch, I'm marking it as "applied" through
> Woof! adding "X-Woof-Patch: applied" in the headers.
next prev parent reply other threads:[~2020-10-24 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 6:27 [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict Adrian Kummerländer
2020-10-10 23:10 ` Jack Kamm
2020-10-24 11:53 ` Bastien
2020-10-24 14:06 ` Jack Kamm [this message]
2020-10-24 14:50 ` Bastien
2020-10-25 13:25 ` stardiviner
-- strict thread matches above, loose matches on Subject: below --
2020-10-06 21:44 Adrian Kummerländer
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).