emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jack Kamm <jackkamm@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org,
	"Adrian Kummerländer" <adrian.kummerlaender@student.kit.edu>
Subject: Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict
Date: Sat, 24 Oct 2020 07:06:26 -0700	[thread overview]
Message-ID: <87lffvn2fx.fsf@gmail.com> (raw)
In-Reply-To: <87blgrn8l7.fsf@gnu.org>

Thanks Bastien, the Woof! tool looks interesting.

By the way, on seeing this thread again, I realized this patch probably should have been applied to the maint branch. So I've cherry picked it into there, and merged back into master.

Bastien <bzg@gnu.org> writes:

> Hi Jack and Adrian,
>
> Jack Kamm <jackkamm@gmail.com> writes:
>
>> Adrian Kummerländer <adrian.kummerlaender@student.kit.edu> writes:
>>
>>> I noticed that after updating to Org 9.4 many of my Python-based Org
>>> files fail to execute with various `io.TextIOWrapper' related error
>>> messages. The reason for this is that opening the exec tmpfile as `f'
>>> shadows this possibly user-defined variable.
>>>
>>> The attached patch fixes this problem for me. As this is my first
>>> time contributing to Org I am especially open for any suggestions!
>>
>> The patch looks good.  I've pushed it to master, after making a couple
>> minor fixes to the commit message (adding a TINYCHANGE cookie and
>> adjusting some of the spacing).
>
> Thanks for applying the patch, I'm marking it as "applied" through
> Woof! adding "X-Woof-Patch: applied" in the headers.
>
> Best,
>
> -- 
>  Bastien


  reply	other threads:[~2020-10-24 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  6:27 Adrian Kummerländer
2020-10-10 23:10 ` Jack Kamm
2020-10-24 11:53   ` Bastien
2020-10-24 14:06     ` Jack Kamm [this message]
2020-10-24 14:50       ` Bastien
2020-10-25 13:25         ` stardiviner
  -- strict thread matches above, loose matches on Subject: below --
2020-10-06 21:44 Adrian Kummerländer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lffvn2fx.fsf@gmail.com \
    --to=jackkamm@gmail.com \
    --cc=adrian.kummerlaender@student.kit.edu \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).