From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IJKPCcpGvV9vEwAA0tVLHw (envelope-from ) for ; Tue, 24 Nov 2020 17:45:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sL5yBcpGvV/fUQAA1q6Kng (envelope-from ) for ; Tue, 24 Nov 2020 17:45:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8FBBD9401BC for ; Tue, 24 Nov 2020 17:45:45 +0000 (UTC) Received: from localhost ([::1]:60164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khcNs-0002xu-3E for larch@yhetil.org; Tue, 24 Nov 2020 12:45:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khcMS-0002nU-W2 for emacs-orgmode@gnu.org; Tue, 24 Nov 2020 12:44:17 -0500 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:46562) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1khcMR-0006DP-1P for emacs-orgmode@gnu.org; Tue, 24 Nov 2020 12:44:16 -0500 Received: by mail-qk1-x72f.google.com with SMTP id b144so7016258qkc.13 for ; Tue, 24 Nov 2020 09:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:user-agent:from:to:subject:message-id:date:mime-version; bh=CB+4KM7GpM9j+r8ywFkNr6aEcU/I0KJqqVXYechajnI=; b=asmf/ZfGMNg6Yk3mq9qOVTAiVF3UQ47sSUV7RbdK0zT6BdS9hyG4cILKNz3u1dK0J2 zNzdyauDvTcLaDBirx8ncLldRX5CcyKn3HPWCbPDQ+BpdwrSIT1gN7kSY8chfZ30vjQA wp3oO9jEyjonGYVkbpPBjdP6n4oeQHgr6kFkcEf7rjduyEAQyN0bXOi4N39so3Km/c/m KVboVnBPbq+83aajd3Is4ghwWjWz8KsrUau6GOH+SLE8VAqyu6KAAxfyDUDTWU4agABe pME6VYTgAXO7aZlLSuV6nAiBj3NnAz1RMjude8oTwLUTJdoUWBZzdIVpl4X6338V+s1T SLpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:user-agent:from:to:subject:message-id :date:mime-version; bh=CB+4KM7GpM9j+r8ywFkNr6aEcU/I0KJqqVXYechajnI=; b=Aob08J+fAVnitNxebxSRd05wRHCF/ih7UA1rrA6tCIqpxXwpACl7H5Vtbgg40xRx3v BZMarJvG2jaRQ0hH+a/miOA9/nPOVzPQfQ1BOMgcbps/lX3NwnMK1YWD+6Gg+hGtPgtD quRj0XxhimzM51CESiMXH+CMhpLLsCXcQcRPJiQmxzEy1w4bQg1WaCzkTVX97MDpL/BG s3QWjbmYY6ADK2X72G0/QrnfucmGEhfz/QEuN/hTFHI2+MUpbAKjsFJP7IO92a7Yxv3J o4oR7RwYSyi2HVGmACxPOtGovSLMxmsSX6m0n+6a1YAXNaMLqRsIl51Zsm+qNf8+x+62 aejg== X-Gm-Message-State: AOAM531b+8lSr6H4H7Xj/cZBJxr/skW55CRo8vm54A3AFkZ7JUN8eiWp ChH9rW308vkPTYzd9l4Q5FhRfoBP7fKbBw== X-Google-Smtp-Source: ABdhPJzp9HFi0COXUF7rUZQA29ag9nLFTQMtSxDZNUxcr68XMz2C0EYFJKKLa7ETfBCqfBQP1vLIzw== X-Received: by 2002:a37:9c41:: with SMTP id f62mr5641666qke.97.1606239853698; Tue, 24 Nov 2020 09:44:13 -0800 (PST) Received: from gusbrs-laptop ([156.146.58.226]) by smtp.gmail.com with ESMTPSA id u5sm10049478qka.106.2020.11.24.09.44.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 09:44:13 -0800 (PST) User-agent: mu4e 1.4.13; emacs 27.1 From: Gustavo Barros To: emacs-orgmode@gnu.org Subject: Bug: org-link-descriptive and org-toggle-link-display [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)] Message-ID: <87lfeqzm3a.fsf@gmail.com> Date: Tue, 24 Nov 2020 14:44:09 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=gusbrs.2016@gmail.com; helo=mail-qk1-x72f.google.com X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=asmf/ZfG; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: IMVFNy7z3CUc Hi All, there is a scope mismatch in `org-toggle-link-display' between text (visibility) properties and the setting of `org-link-descriptive'. The text properties are set for the buffer with either `remove-from-invisibility-spec' or `add-to-invisibility-spec', but the value of `org-link-descriptive` is set globally with `(setq org-link-descriptive (not org-link-descriptive))'. It is not a big deal, but it does lead to a glitch in `org-toggle-link-display'. It is easy to generate an ECM to trigger the glitch: - Start `emacs -Q' - Load the latest: #+begin_src emacs-lisp (add-to-list 'load-path "~/.emacs.d/elpa/org-plus-contrib-20201123") #+end_src - Open two Org buffers "*Buffer 1*" with contents: #+begin_src org [[https://orgmode.org/][Org mode for Emacs]] #+end_src - And "*Buffer 2*" with contents: #+begin_src org [[https://orgmode.org/worg/][Hello Worg, the Org-Mode Community!]] #+end_src - It's probably easier to visualize if you have both windows in view in a split frame, but it should not change the result whatever you do. - The initial state, as per defaults, is that links are invisible in both buffers. - Go to "*Buffer 1*" and `M-x org-toggle-link-display', and links are made visible in that buffer, but not in "*Buffer 2*". - Now, go to "*Buffer 2*" and call `M-x org-toggle-link-display' there. It doesn't work. Call it again. Now it does. What's happening is that, when we call `org-toggle-link-display' in "*Buffer 1*" we set `org-link-descriptive' to nil globally, so that when we move to "*Buffer 2*", Org thinks the links are visible, and when we call `org-toggle-link-display' then, Org will try to "re-hide" the links that are already invisible, with no apparent effect. But, in doing so, it also sets `org-link-descriptive' to t again, also globally. And so a second call will work. I don't know if it's better to make `org-link-descriptive' buffer-local, or to simply use `setq-local' in `org-toggle-link-display'. Either way, it is a low hanging one. Best regards, Gustavo. Emacs : GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-08-11 Package: Org mode version 9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/) current state: ============== (setq org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer) org-link-shell-confirm-function 'yes-or-no-p org-metadown-hook '(org-babel-pop-to-session-maybe) org-clock-out-hook '(org-clock-remove-empty-clock-drawer) org-link-descriptive nil org-mode-hook '(#[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-show-all append local] 5] #[0 "\300\301\302\303\304$\207" [add-hook change-major-mode-hook org-babel-show-result-all append local] 5] org-babel-result-hide-spec org-babel-hide-all-hashes org-eldoc-load) org-archive-hook '(org-attach-archive-delete-maybe) org-confirm-elisp-link-function 'yes-or-no-p org-agenda-before-write-hook '(org-agenda-add-entry-text) org-metaup-hook '(org-babel-load-in-session-maybe) org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3 "\n\n(fn ENTRY)"] org-babel-pre-tangle-hook '(save-buffer) org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand) org-agenda-loop-over-headlines-in-active-region nil org-src-lang-modes '(("redis" . redis) ("php" . php) ("arduino" . arduino) ("C" . c) ("C++" . c++) ("asymptote" . asy) ("bash" . sh) ("beamer" . latex) ("calc" . fundamental) ("cpp" . c++) ("ditaa" . artist) ("dot" . fundamental) ("elisp" . emacs-lisp) ("ocaml" . tuareg) ("screen" . shell-script) ("shell" . sh) ("sqlite" . sql)) org-occur-hook '(org-first-headline-recenter) org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines org-optimize-window-after-visibility-change) org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate) org-export-before-parsing-hook '(org-attach-expand-links) org-confirm-shell-link-function 'yes-or-no-p org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link) ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link) ("rmail" :follow org-rmail-open :store org-rmail-store-link) ("mhe" :follow org-mhe-open :store org-mhe-store-link) ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export) ("info" :follow org-info-open :export org-info-export :store org-info-store-link) ("gnus" :follow org-gnus-open :store org-gnus-store-link) ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link) ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link) ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store org-bbdb-store-link) ("w3m" :store org-w3m-store-link) ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell) ("news" :follow #[514 "\301\300\302Q\"\207" ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("mailto" :follow #[514 "\301\300\302Q\"\207" ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("https" :follow #[514 "\301\300\302Q\"\207" ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("http" :follow #[514 "\301\300\302Q\"\207" ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("ftp" :follow #[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"] 6 "\n\n(fn URL ARG)"]) ("help" :follow org-link--open-help) ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp) ("doi" :follow org-link--open-doi)) org-link-elisp-confirm-function 'yes-or-no-p )