From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EKlCIvra6mBVUQAAgWs5BA (envelope-from ) for ; Sun, 11 Jul 2021 13:50:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AKvrHfra6mAwSwAAbx9fmQ (envelope-from ) for ; Sun, 11 Jul 2021 11:50:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 298F628740 for ; Sun, 11 Jul 2021 13:50:18 +0200 (CEST) Received: from localhost ([::1]:52804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2XyT-0006Py-7w for larch@yhetil.org; Sun, 11 Jul 2021 07:50:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2XxN-0004HU-3C for emacs-orgmode@gnu.org; Sun, 11 Jul 2021 07:49:09 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:34708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2XxL-0008K0-LY for emacs-orgmode@gnu.org; Sun, 11 Jul 2021 07:49:08 -0400 Received: by mail-wr1-x42c.google.com with SMTP id p8so20314057wrr.1 for ; Sun, 11 Jul 2021 04:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:cc:date:message-id :mime-version; bh=glTQYwV/dmsYZLFjNfoe5g1PaJNFG5kTSGkmWahQmJ4=; b=fQoIkBLcpGBBlZRySKzZJKGIg6xFnCMqFD+Ds/fdJfSlagnuUeBYWOBW7mnMUbFp0e siQdYFXkM7ssPo3qYTsBYoy26J4+sOXytSx1jQNHb1MYchUwzx4+yeUnhWCDtMwJMvPU m9Cr18kMZou/LphuEbkP/DwR6p5n2DUVpjxNW7YYMh+8Hw6wqkQrojQPyLdTV3JFh5U5 jHGcb3PWQzTRmG0KrqdsQx+LtjaEJjlV9qJfl0e33w5D0YxB41NLihVZ3RMY+XzxIcrn hsP0UQSy0ziQ1invgDVtdyMGnMIyMfbe19Qha3vZXwHd6a9pPe237p78Lg3M5b7W5KSS NcCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:cc:date :message-id:mime-version; bh=glTQYwV/dmsYZLFjNfoe5g1PaJNFG5kTSGkmWahQmJ4=; b=mLWUk0V7e7HzZqgp11RegNi1ujoAtY6cmWs4Rv2xuSelqM5kGLK1t88Tuh1XOaT3tn 1soBpPKvp8Opv0w2s4QS+UZh3+/TMb3PqiunoNfvHA9VX9X+D91+bQa/6d9jgIHuo6k9 W+Pje7xGrmjoy7J2+yK6mMlxcgedOiOWbc4Jn6GfGThcW15A7OMgTygovHgz1ua3TO7F 7VIQR6kDFQXeyF0GvuA9mnBWrFTsLmQ5Pq3G7aJstFqe6a/pZrfuHl6pSrLHk8Ks8Q/3 J71NHrPfS4w5jQRE1jsi0+kLYTq8kW5ZPwrkvAbTDldHG4Sgq64nfYQnZaGyePiiGaCp i7OQ== X-Gm-Message-State: AOAM533b/bN+pSDMubSiBqdpQtgxWUEZmr2QCa4iSneXGA1FLGoIYUjF e5N5kLoblziQLfwvKWVYYzA= X-Google-Smtp-Source: ABdhPJxD7ej0Ai/zZnJo2a92RPyc/wQGGP6fBEts6AmsuvoSz7TAdpE1NbghU19BM6EBT9zh+6Wqgw== X-Received: by 2002:a5d:46c8:: with SMTP id g8mr28338799wrs.341.1626004146082; Sun, 11 Jul 2021 04:49:06 -0700 (PDT) Received: from localhost ([158.255.2.9]) by smtp.gmail.com with ESMTPSA id r16sm8799495wmg.11.2021.07.11.04.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 04:49:05 -0700 (PDT) From: Ihor Radchenko To: Maxim Nikulin Subject: Re: [BUG] org-goto slows down org-set-property In-Reply-To: References: Date: Sun, 11 Jul 2021 19:49:08 +0800 Message-ID: <87lf6dul3f.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=yantar92@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626004218; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=glTQYwV/dmsYZLFjNfoe5g1PaJNFG5kTSGkmWahQmJ4=; b=XQ5fDYj4sbD73M+o77LZVxQHYvIEMHsbIXTXjKN0hMNR9MNS3ROcxoNMhPxSAvqS78B4wv spOI/z2R6Dc5MZeIbgZFzEfZm/MnaPe4Jkt5gg6Hq9k1rPCdz+F2O5dvIDWMg+JkyvJKEv OQDvgfC0mjZJk9HyiwR2bLoZRGORkGjsmqrbEF67HGOgcoMm2dRVuBFEJuU/lj4k5yKEoD K3dYmdxLtP/mtbaKhOt4eqkhMoyjvaqDelwLFTyQXPKtOGj26LqA8/URsmAX4JVgCkEFJg WK1Lft/BtMGxmKoFSNpQZLVu94Fr4VF7qmIaXRlSpg4gZrB7Zz752T7EFGT0iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626004218; a=rsa-sha256; cv=none; b=awNu44eNLhXd4u82tp4F3xu2wTa5fDNXjp3ugUdsfzJ78xv8Rx4J1j8TajjKhKvB/c6ouZ txb3EyuoJSALNkiW0rXofcF0g4+lxrikY4kdLAwlXxyyneBwGilpLmkYyKCYLDlSMqLOEu 8YoOjocRM/0hgJVj2UpiwXa5k1DApqo7sdYFOpPzhZDo2peBCbvLCs3z9mHqQTTw6RT7zS pkSAe20KPbVxddxNMSF1xtd/HHbllvOc43kvhZ9kbPxarn4f66pbdGgcsVQWbQgFNoDPDx uBvRr4brKPqta+4u4PKXHq55mpMmkpKs4q3l8cc1P/zcFFvnLZmo6h/F3Sn4PA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fQoIkBLc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=fQoIkBLc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 298F628740 X-Spam-Score: -2.61 X-Migadu-Scanner: scn1.migadu.com X-TUID: 7Kymjq27CtKl Maxim Nikulin writes: > It seems, it is better to drop org-refile-cache completely. It has some > design problems making it rather fragile. At the same time a patch can > be applied that improves performance of `org-refile-get-targets' by a > factor of at least 2 for (org-refile-use-outline-path 'file). I tend agree. I got rid of org-refile-cache some time ago in favour of org-ql. The performance is much better subjectively, which indicates that alternative caching mechanisms could be much better. Your test on my 12M chars 18k headings org file (Emacs master, Org mode master). I cannot use org-set-property even without org-refile-cache :( #+RESULTS[e3fd8ffd9dd1a1d1cb8cf2ab3927bf647e944dd8]: | 9.4.6 | | | | | nm-tst | 13.638543295000002 | 4 | 1.9903503830000204 | | org-refile-get-targets | 5.355179174 | 2 | 0.97954138099999 | | nm-tst | 22.599429478 | 4 | 2.0785714209999924 | | org-refile-cache-clear | 0.003903494 | 0 | 0.0 | | nm-tst | 13.969909913 | 4 | 2.06943181500003 | Best, Ihor