From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YDBMNyMqLmH5+QAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 15:09:55 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KIofMyMqLmFyCgAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 13:09:55 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 607C11404C for ; Tue, 31 Aug 2021 15:09:55 +0200 (CEST) Received: from localhost ([::1]:35748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mL3WU-0008Nq-Ez for larch@yhetil.org; Tue, 31 Aug 2021 09:09:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL36c-0007MW-9l for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 08:43:12 -0400 Received: from mail.ptlnet.com ([94.229.138.130]:51706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mL36V-0006yk-BI for emacs-orgmode@gnu.org; Tue, 31 Aug 2021 08:43:07 -0400 Received: from inspiron.notlocalhost ([10.9.0.1]) by mail.ptlnet.com (8.15.2/8.15.2) with ESMTPS id 17VCgl2j029769 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 31 Aug 2021 13:42:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=precedence.co.uk; s=mail; t=1630413768; bh=QPMSMR0NJGVOGa2PtswntNbI/T30rZYL76ruRtQti6k=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=UOsos7e7SpijSYc1kTbcJ8r9Idq1pi2wtERG5RNtzqbOWnAXcfo+ykCB+G4FHfds5 61ZXPCXZ2orwLc3Ns620ec32uwKvYkLSOAXcKvKc0QIO+eb9ZvXOMsfF6fec3+tLDc H6LbABU6Z2ATEf3QNvV82I9HMYn9NZVGuhkRjueE= From: Morgan Willcock To: Timothy Subject: Re: [PATCH] ox-ascii.el: Fix justify when `indent-tabs-mode' is non-nil References: <20210817230735.13336-1-mwillcock@precedence.co.uk> <87zgsxom7k.fsf@gmail.com> Date: Tue, 31 Aug 2021 13:42:46 +0100 In-Reply-To: <87zgsxom7k.fsf@gmail.com> (Timothy's message of "Tue, 31 Aug 2021 19:59:52 +0800") Message-ID: <87lf4hn5tl.fsf@precedence.co.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mail.ptlnet.com [192.168.10.250]); Tue, 31 Aug 2021 13:42:48 +0100 (BST) Received-SPF: pass client-ip=94.229.138.130; envelope-from=mwillcock@precedence.co.uk; helo=mail.ptlnet.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630415395; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=VHp3E2uylJm67+Q2Xmm2QV4QaLOiHBHJpw6I3jrIqwY=; b=dGWRYhcmVlkArCXJPP/QNU5QPadjGkK4YnvHma0PqAGDna1W6qgURaVLMRpKCTcwut6uyJ Ch7FyN8REvyvPTkHoDvG/RIHqg99Yf+RjQpm2cocTWyPOSRpukrb5zR+XPwlmGW4Q6kjOC gsxl19Vzng3sBtAkAHkJuUyPMF1c82GVD1168oV9xKOaSlcYwyi9vRauioFNGK7R//AkGB bclxpRkEgIrg9fbV973mcAsyL4HRAH5TWgK4rJqI/0JtWnpEkZ4AmQL+jcTN1tGu0KV3YQ KiPqIUNdKeVyDmFwDtx6GvmhWmBzFn4Cx2YQpIfSWcFE18XewLWVJD0lWajJRw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630415395; a=rsa-sha256; cv=none; b=qxxAsB+W4hXFPNCVBzm+iSHfoCaR5tH8dz/fJ685gXF2AwGCaWDLTwDdCA9vmTkUtA2Gh4 qj6GX4Ntsp/J3HXpBGtGoQz5VYj8SlECAy+KnFWqgu2MZ9siwSVG2qKvQR8XQsd2TrTV0J ngzqURn9yJfuvx2+W01/fDMjGQ8JAZDCPAjrkxuBYmZaOYLC4jloZgelBfIJ5eM8Yvz4eU Cc9cjWK9OpK6Nn/xmx4a8pEnct/S5XtV3xRvWSmEehehT8IoDsw2EYBk0pDT/OCYaOOwYQ qhTBQw73JWCsmQdLtPzAiYnlEls56VI+mLKjmdbrg35koWDRe5xQh2mIyQjaxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=precedence.co.uk header.s=mail header.b=UOsos7e7; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=precedence.co.uk header.s=mail header.b=UOsos7e7; dmarc=pass (policy=none) header.from=precedence.co.uk; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 607C11404C X-Spam-Score: -1.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: tPzX4I7qmFNI Timothy writes: > Hi Morgan, > >> I=E2=80=99ve attached a patch to fix an issue where tab characters are g= enerated by >> the ASCII exporter when `indent-tabs-mode=E2=80=99 has its default value= of t. > > Thanks for finding this bug, fixing it, and sending us it =F0=9F=99=82. I= was able to > reproduce your test case with =E2=80=9Cemacs -Q=E2=80=9D (thanks for that= , by the way). > As you suspected, with the small number of changed lines, this would be f= ine to > accept without FSF assignment. Great! Thank you for taking a look. > However, your =E2=80=9Cpatch=E2=80=9D seems to consist of a diff at the b= ottom of your email and > a commit message at the top?? It would be preferable if you could provide= a > =E2=80=9Cproper=E2=80=9D patch, that way you can get attribution for your= help instead of just > someone committing it on your behalf. I used `git send-email` which is listed as being OK on the website: "If you have configured git to use send-email, then you can use that." -- https://orgmode.org/contribute.html The mail can be applied with `git am` and the commit message will be correct. I'm also happy to resend as a separate patch if that is the requirement. Thanks, Morgan