From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gFSsKb3uYWF0HgAAgWs5BA (envelope-from ) for ; Sat, 09 Oct 2021 21:34:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UG+zI73uYWEcOwAAbx9fmQ (envelope-from ) for ; Sat, 09 Oct 2021 19:34:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DB8A312122 for ; Sat, 9 Oct 2021 21:34:20 +0200 (CEST) Received: from localhost ([::1]:43430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZI6t-0002cZ-C3 for larch@yhetil.org; Sat, 09 Oct 2021 15:34:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZI6J-0002cC-9p for emacs-orgmode@gnu.org; Sat, 09 Oct 2021 15:33:43 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:35242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZI6F-0005tE-Mg for emacs-orgmode@gnu.org; Sat, 09 Oct 2021 15:33:43 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1633808014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t1LLAWfXYWG42P9zV25pYnO63BSbE2eoHh9VyiVSTUA=; b=EzRIdyzDTo8P6d6Jvd61YzQC88wiTCmoAVrXXB0YNQMNUOJuuO7o5Si+N6fgMMEDjcxxyg cq0BI0opynqNthMtQzXyInJh/CH0AQeunanalX2EaBBZSTY2Zg4olNAQIYPnmDG9ALnq/r skZhv2llpbSRWLhVhzxhSrzq7hYFQNfungiOy/VlZL4EANawAqnFa/lC0JuUtBwle8fUyC aWoNVsIDupLegF5bDjTdHkp6Z/aJaJdI5pVvYXYS+18F8A3EaeHKFPgO6H6XdKW6tTf+mQ wfXhrDfibr0t1gkdg5PJH2ywtj3BOE1C/XXeV5L8mY4JGO7CVWMZcyUt98ijCg== From: Kyle Meyer To: No Wayman Subject: Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)] In-Reply-To: <87zgrmc2rg.fsf@gmail.com> References: <87zgrmc2rg.fsf@gmail.com> Date: Sat, 09 Oct 2021 15:33:23 -0400 Message-ID: <87lf32kn7g.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=kyle@kyleam.com; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633808061; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=t1LLAWfXYWG42P9zV25pYnO63BSbE2eoHh9VyiVSTUA=; b=JeXJFG8grD5ujkHao911zCY/efiawOpGKkkYa/Nrh0mwyk2VO0uaV8MykVGLC8s6qatMsC cjOuQJ68T3PvL9q0mmEdeZJdQbrYT7NljXb33CqS+ZhtcxOCpmAN0RSXWV8tq/nuBDj8ij C3zo3a4SpH0EATJCC6nMb0JDx48G6oCZmuLjOx+NsCoR41mF4X9f3S3l2JqIuxPT5o0xSU zmh3scsDsGyD8XWKz/XDgD2LYq+5IUAi9mLrffYYeGFkn04q1mUuK82x/s5l0+jKMTPMmc gBg81g0wgTfRP7TZKnUucLPicxW1qbLLkWWkLVTfigefB9LvkYv1ch/XMOe4Vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633808061; a=rsa-sha256; cv=none; b=CwmLtrZvY2/gNVf5bk6oJnwnBHugBkep55W0l7Q6fKivD4IY8cr7lE9suEb7YwhRKLwua9 bkVvbkXteVlPv+61JTNIuN4Y1rmLm/Qa4poQ9hP+toOLpHbf0a5TKjrrF9HR3AvrCqtyqE UdTMfqOVVyW6OPVYwcpIG1grVtt9QMfB4LPx/fmfxabksnjvb19foNaBtx9/Gxv5+HBBvm gScFrRkNEifstee9AmoWjlbDKPIuMMD6LNLUzaBVsqFUofMROujJRPQLokg0t2VLjrn+fV TJl9DJQ9OXBGHwQZ0xAIEy8Re05bExabkLo95DbSlxYWcqtP11vmDd8RIVfCMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=EzRIdyzD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kyleam.com header.s=key1 header.b=EzRIdyzD; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DB8A312122 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: QcuahUTYfKM9 No Wayman writes: > Subject: [PATCH] lisp/org.el: (org-save-all-org-buffers): Prevent `org-mode' > reload > > * lisp/org.el: (org-save-all-org-buffers): Ensure `save-some-buffers' PRED returns boolean. > > As of this upstream commit: > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a9ad3d477441feefa3bf6107d58281cb64e0e78a > > `save-some-buffers' will call its PRED argument if it returns a function. > Since (derived-mode-p 'org-mode) returns the symbol org-mode, > and org-mode is a function, org-mode is reloaded in modified Org > buffers when calling `org-save-all-org-buffers'. Among other > undesirable behavior, this will cause the buffer's visibility to be > reset to its initial visibility. Thanks for the analysis and fix. To git.savannah.gnu.org:/srv/git/emacs/org-mode.git 11f450da8..b71474ff7 bugfix -> bugfix