emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: No Wayman <iarchivedmywholelife@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]
Date: Sat, 09 Oct 2021 15:33:23 -0400	[thread overview]
Message-ID: <87lf32kn7g.fsf@kyleam.com> (raw)
In-Reply-To: <87zgrmc2rg.fsf@gmail.com>

No Wayman writes:

> Subject: [PATCH] lisp/org.el: (org-save-all-org-buffers): Prevent `org-mode'
>  reload
>
> * lisp/org.el: (org-save-all-org-buffers): Ensure `save-some-buffers' PRED returns boolean.
>
> As of this upstream commit:
>
> https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=a9ad3d477441feefa3bf6107d58281cb64e0e78a
>
> `save-some-buffers' will call its PRED argument if it returns a function.
> Since (derived-mode-p 'org-mode) returns the symbol org-mode,
> and org-mode is a function, org-mode is reloaded in modified Org
> buffers when calling `org-save-all-org-buffers'. Among other
> undesirable behavior, this will cause the buffer's visibility to be
> reset to its initial visibility.

Thanks for the analysis and fix.

  To git.savannah.gnu.org:/srv/git/emacs/org-mode.git
     11f450da8..b71474ff7  bugfix -> bugfix


  reply	other threads:[~2021-10-09 19:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 13:14 Marcel van der Boom
2021-10-05 17:53 ` Bhavin Gandhi
2021-10-06  2:08 ` No Wayman
2021-10-09 19:33   ` Kyle Meyer [this message]
     [not found] <cdd5fdae-5c61-916b-9e6e-9e9d51a0a834@ctpowe.net>
2021-10-05 19:51 ` Fwd: " Michael Powe
2021-10-08 11:55   ` Lennart C. Karssen
2021-10-08 22:00     ` Mark Barton
2021-10-08 22:30       ` Mark Barton
2021-10-09 16:38         ` No Wayman
2021-10-09 18:43           ` Mark Barton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lf32kn7g.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --subject='Re: [BUG] org-save-all-org-buffers reapplies startup visibility [9.5 (release_9.5 @ /usr/local/share/emacs/29.0.50/lisp/org/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).