From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oIzcBf1BmWOivgAAbAwnHQ (envelope-from ) for ; Wed, 14 Dec 2022 04:24:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aLndBf1BmWNoSAEA9RJhRA (envelope-from ) for ; Wed, 14 Dec 2022 04:24:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C268FE544 for ; Wed, 14 Dec 2022 04:24:44 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5IN7-0001Xh-8E; Tue, 13 Dec 2022 22:23:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5IN5-0001XU-6e for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 22:23:51 -0500 Received: from out-211.mta0.migadu.com ([91.218.175.211]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5IN3-0007Oh-5d for emacs-orgmode@gnu.org; Tue, 13 Dec 2022 22:23:50 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1670988226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h/Cnv7Nig28BiZtHbaiyccdbDJAnGF66J6tSDgLBgHU=; b=zrVVKhd9vcOLiTt233yWyXqkHIkkhPz2fdd5cni+2iAfxYnIXSkkDYXLAfAvQjzLCcRYMv 0HGsKO1aZZhpPYGM6Fw9yeFN0fdLfZFKsa1E1n2Go6G+K+z1VG9eI9ERHnjkq3+KiBAI6M ZykXlQgRQXjr4wG/wqcIw8PpAhXGgxXf27EUo7sG9JKLrFwobfHIcNR+5Pul0afh4rjxJu DneFAkeHxdTwG52k+nHADHV+NjHigsYX7Nu9MyDuqTgoGIzI9Us27uo5cXuoqxiBA6c/gw 9z3fSVBmQ2kcGiDc46Jmxl5NBruz3zUWWy0n2ytOOl5jSR8+eZBkQHsKX/Kgew== From: Kyle Meyer To: Ihor Radchenko Cc: emacs-orgmode@gnu.org Subject: Re: 2a529ee57 org-element: Autoload org-element-use-cache In-Reply-To: <87pmcnela2.fsf@localhost> References: <87pmcnela2.fsf@localhost> Date: Tue, 13 Dec 2022 22:23:44 -0500 Message-ID: <87lenabrcv.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=91.218.175.211; envelope-from=kyle@kyleam.com; helo=out-211.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670988284; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=h/Cnv7Nig28BiZtHbaiyccdbDJAnGF66J6tSDgLBgHU=; b=POpN63Yi69A/OSyUKCQFkXHbuGcU6CX0/Kixdn+qGifnHvbd4cK8770/H6rw4UkAG6NTfh d3D1nSkxAY3vR76dcdwMQLiLzAO2weCK6NoH75g/HDhvVSiUkf8vqmC2Ibrz1XIKplamcN xwx57PknsIrVtAg4ZsgfB2Z0NJ4I4jZOXKSY+SxzJpQ0K/YKCUPcOBmrjqdQbkgAn0xa6z Vh0klrVQ0J46f1XDkpNg/avKTvvSDnsaqdFLfPhwMTIsxfaNembn/Sz/b9bbJRaXxjDFEs 3NqmpYoNBB8Q5O5HKP+qaoeo3JE06bbRprJG2Jjqh0nefnXURIDNZwrZSJn2eg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=zrVVKhd9; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670988284; a=rsa-sha256; cv=none; b=ixQpCelMz3R5P3aX/c/5ZOp3eY/8ODj4zGvchgQlyCfT60rv76araCIjRsDhR5/dvluInt ekm4o01TfK9TEeKrUJFQwpiNhP6+sO+f9TV95z//mCmFwMAtcwGs2jkJ2Yip/709Evzwpd jYnZIkHupPclWcMb9+jd3QwyRUBwDACRarykC8ODN8RBJC6MgNFkaxcHSSdeZDkUV+ryBg DItSzVdMNOJV1bpCNRIHxsw83jy7DnQApUWJF/2GtYb/OAqsDchtjRp/qVjAdyDxJKW8Va ZbIrC9l4cAHZEn/g4MKZerjHDJHVroFaSVIa6wNckuXI2Qj3z35JnqnEyU6mog== X-Migadu-Spam-Score: -3.91 X-Spam-Score: -3.91 X-Migadu-Queue-Id: C268FE544 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=zrVVKhd9; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: AjV/ioHnL7aV Ihor Radchenko writes: > You wrote in the commit message that autoload.el is deprecated in Emacs > 29. Do we need to do anything about it in Org make system? Yes, though I don't consider it urgent given the deprecation hasn't even made it into a release. I was planning on doing something like below (only lightly tested at this point). And then way down the road we can drop the compatibility kludge. diff --git a/mk/org-fixup.el b/mk/org-fixup.el index 5989875a8..60c39c684 100644 --- a/mk/org-fixup.el +++ b/mk/org-fixup.el @@ -24,7 +24,6 @@ ;; ;;; Commentary: -(require 'autoload) (require 'org-compat "org-compat.el") (defun org-make-manual () @@ -86,18 +85,22 @@ (defun org-make-org-loaddefs () be used by foreign build systems or installers to produce this file in the installation directory of Org mode. Org will not work correctly if this file is not up-to-date." - (with-temp-buffer - (set-visited-file-name "org-loaddefs.el") - (insert ";;; org-loaddefs.el --- autogenerated file, do not edit\n;;\n;;; Code:\n") - (let ((files (directory-files default-directory - nil "^\\(org\\|ob\\|ox\\|ol\\|oc\\)\\(-.*\\)?\\.el$"))) - (mapc (lambda (f) (generate-file-autoloads f)) files)) - (insert "\f\n(provide 'org-loaddefs)\n") - (insert "\f\n;; Local Variables:\n;; version-control: never\n") - (insert ";; no-byte-compile: t\n;; no-update-autoloads: t\n") - (insert ";; coding: utf-8\n;; End:\n;;; org-loaddefs.el ends here\n") - (let ((inhibit-read-only t)) - (save-buffer)))) + (let ((outfile "org-loaddefs.el")) + (if (fboundp 'loaddefs-generate) ; Emacs >= 29 + (loaddefs-generate default-directory (expand-file-name outfile)) + (require 'autoload) + (with-temp-buffer + (set-visited-file-name outfile) + (insert ";;; org-loaddefs.el --- autogenerated file, do not edit\n;;\n;;; Code:\n") + (let ((files (directory-files default-directory + nil "^\\(org\\|ob\\|ox\\|ol\\|oc\\)\\(-.*\\)?\\.el$"))) + (mapc (lambda (f) (generate-file-autoloads f)) files)) + (insert "\f\n(provide 'org-loaddefs)\n") + (insert "\f\n;; Local Variables:\n;; version-control: never\n") + (insert ";; no-byte-compile: t\n;; no-update-autoloads: t\n") + (insert ";; coding: utf-8\n;; End:\n;;; org-loaddefs.el ends here\n") + (let ((inhibit-read-only t)) + (save-buffer)))))) (defun org-make-autoloads (&optional compile force) "Make the files org-loaddefs.el and org-version.el in the install directory.