emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: Evgenii Klimov <eugene.dev@lipklim.org>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org.el: Remove undefined dynamic variable `org-log-states' from example
Date: Tue, 11 Jul 2023 09:11:26 +0000	[thread overview]
Message-ID: <87lefmols1.fsf@localhost> (raw)
In-Reply-To: <e900a08d-11af-9106-423e-28a2befe813d@gmail.com>

Max Nikulin <manikulin@gmail.com> writes:

> On 11/07/2023 06:11, Evgenii Klimov wrote:
>> I added `org-summary-todo' example function, that are advertized in
>> `org-after-todo-statistics-hook', to my init file (with
>> lexical-binding: t) and got a compilation warning:
>> 
>>    Warning (bytecomp): Unused lexical variable `org-log-states'
>
> May it be a typo? There is the `org-todo-log-states' variable added in
>
> : 70b6cc5da 2008-01-31 11:36:18 +0100 Carsten Dominik: Release 5.10a

Indeed.
I fixed it myself on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=0b6f9f

Handled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-07-11  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 23:11 [PATCH] org.el: Remove undefined dynamic variable `org-log-states' from example Evgenii Klimov
2023-07-11  2:24 ` Max Nikulin
2023-07-11  9:11   ` Ihor Radchenko [this message]
2023-07-12 13:42 ` Ihor Radchenko
2023-07-12 20:53   ` Evgenii Klimov
2023-07-13 11:29     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lefmols1.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=eugene.dev@lipklim.org \
    --cc=manikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).