emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Visuwesh <visuweshm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-plot: Unable to use text xtics with type:2d (+ more) [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)]
Date: Sat, 15 Jun 2024 09:51:15 +0000	[thread overview]
Message-ID: <87le36ilf0.fsf@localhost> (raw)
In-Reply-To: <87ikyd48f8.fsf@gmail.com>

Visuwesh <visuweshm@gmail.com> writes:

> Sorry for the noise, I copied the wrong link in the commit message.
> Please see attached instead.

Thanks!
I have some comments.

> -	   (type (assoc (plist-get params :plot-type)
> -			org-plot/preset-plot-types))
> +	   (type (cdr (assoc (plist-get params :plot-type)
> +			     org-plot/preset-plot-types)))
>             gnuplot-script)

This may break the existing customization.
Later in the function, TYPE is used as an argument for
`org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'.
Some users may have these two custom options adjusted to the older
calling convention.

To not break things, we should pass the full `assoc' to these functions.

Also, while you are at it, may your please clarify what TYPE means in
the docstrings of `org-plot/gnuplot-term-extra' and
`org-plot/gnuplot-script-preamble'?

>  			(setf params (org-plot/collect-options params))))
> +      (setq params (org-combine-plists type params))

May you also drop a short comment in the code that explains what this
line does?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-06-15  9:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 11:18 [BUG] org-plot: Unable to use text xtics with type:2d (+ more) [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] Visuwesh
2024-05-24 12:21 ` Ihor Radchenko
2024-05-24 17:19   ` Visuwesh
2024-06-11  5:41     ` Visuwesh
2024-06-12 12:41     ` Ihor Radchenko
2024-06-13  7:04       ` Visuwesh
2024-06-13  7:18         ` Visuwesh
2024-06-15  9:51           ` Ihor Radchenko [this message]
2024-06-17  5:06             ` Visuwesh
2024-06-17 17:13               ` Ihor Radchenko
2024-06-18  5:10                 ` Visuwesh
2024-06-18 14:29                   ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le36ilf0.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).